Sync eng/common directory with azure-sdk-tools for PR 13222#36838
Merged
Sync eng/common directory with azure-sdk-tools for PR 13222#36838
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the eng/common directory with azure-sdk-tools PR #13222. The change improves the LogGroupStart function in the logging script by adding fallback behavior for environments that don't support DevOps or GitHub Actions logging.
Key Changes:
- Added an
elseclause toLogGroupStartfunction to provide fallback output ("> $args") when neither Azure DevOps nor GitHub Actions logging is available
Comments suppressed due to low confidence (1)
eng/common/scripts/logging.ps1:109
- The
LogGroupEndfunction should also have anelseclause for consistency withLogGroupStart. Currently, if neither DevOps nor GitHub logging is supported,LogGroupStartwill output "> $args" butLogGroupEndwill output nothing, which could lead to unpaired group markers in logs.
Consider adding an else block to maintain symmetry:
else {
Write-Host "< End"
}This pattern is consistent with other logging functions in this file (e.g., LogWarning, LogError, LogDebug) that all provide fallback behavior.
function LogGroupEnd() {
if (Test-SupportsDevOpsLogging) {
Write-Host "##[endgroup]"
}
elseif (Test-SupportsGitHubLogging) {
Write-Host "::endgroup::"
}
}
hallipr
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13222 See eng/common workflow