Skip to content

Sync eng/common directory with azure-sdk-tools for PR 13222#36838

Merged
azure-sdk merged 1 commit intomainfrom
sync-eng/common-users/pahallis/local-group-start-13222
Dec 9, 2025
Merged

Sync eng/common directory with azure-sdk-tools for PR 13222#36838
azure-sdk merged 1 commit intomainfrom
sync-eng/common-users/pahallis/local-group-start-13222

Conversation

@azure-sdk
Copy link
Copy Markdown
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13222 See eng/common workflow

@azure-sdk azure-sdk requested a review from a team as a code owner December 9, 2025 07:14
@azure-sdk azure-sdk requested review from Copilot and hallipr December 9, 2025 07:14
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Dec 9, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs the eng/common directory with azure-sdk-tools PR #13222. The change improves the LogGroupStart function in the logging script by adding fallback behavior for environments that don't support DevOps or GitHub Actions logging.

Key Changes:

  • Added an else clause to LogGroupStart function to provide fallback output ("> $args") when neither Azure DevOps nor GitHub Actions logging is available
Comments suppressed due to low confidence (1)

eng/common/scripts/logging.ps1:109

  • The LogGroupEnd function should also have an else clause for consistency with LogGroupStart. Currently, if neither DevOps nor GitHub logging is supported, LogGroupStart will output "> $args" but LogGroupEnd will output nothing, which could lead to unpaired group markers in logs.

Consider adding an else block to maintain symmetry:

else {
  Write-Host "< End"
}

This pattern is consistent with other logging functions in this file (e.g., LogWarning, LogError, LogDebug) that all provide fallback behavior.

function LogGroupEnd() {
  if (Test-SupportsDevOpsLogging) {
    Write-Host "##[endgroup]"
  }
  elseif (Test-SupportsGitHubLogging) {
    Write-Host "::endgroup::"
  }
}

@azure-sdk azure-sdk merged commit bfe5908 into main Dec 9, 2025
24 checks passed
@azure-sdk azure-sdk deleted the sync-eng/common-users/pahallis/local-group-start-13222 branch December 9, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants