Sync eng/common directory with azure-sdk-tools for PR 12350#36827
Merged
Sync eng/common directory with azure-sdk-tools for PR 12350#36827
Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the eng/common directory with azure-sdk-tools PR #12350, updating stress testing deployment scripts. The changes include adding the SSS3PT_ prefix to stress cluster resource group names to bypass S360 security reporting for legitimate testing scenarios, and introducing validation logic to detect uncommitted changes to addon configuration files.
Key Changes:
- Added
SSS3PT_prefix to cluster group names for pg, prod, and storage environments to disable S360 reporting for 3P testing with local auth - Introduced pre-deployment validation to detect local changes to stress-test-addons values.yaml and require explicit use of
-LocalAddonsPathparameter
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1 | Updated cluster group names for pg, prod, and storage environments to include SSS3PT_ prefix |
| eng/common/scripts/stress-testing/deploy-stress-tests.ps1 | Added validation logic to detect uncommitted changes to values.yaml and enforce use of LocalAddonsPath parameter |
benbp
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12350 See eng/common workflow