-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[AutoPR @azure-arm-elasticsan]-generated-from-SDK Generation - JS-5515645 #36386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[AutoPR @azure-arm-elasticsan]-generated-from-SDK Generation - JS-5515645 #36386
Conversation
…ElasticSan/ElasticSan/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: 'c86c7e36fb15171a9967d9fdc47784f2e4202ca6' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5515645 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR is an automated generation from the SDK generation pipeline for the ElasticSan ARM client library, updating from API version 2024-07-01-preview to 2025-09-01. The changes transition from a classic ARM management SDK to a newer architecture with improved type safety and client operations structure.
- Introduces new preRestore and preBackup volume validation operations
- Restructures the client architecture with separate classic and API layers
- Updates all sample code to use the new client structure
- Removes legacy v1 TypeScript samples and consolidates on v2 structure
Reviewed Changes
Copilot reviewed 266 out of 311 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/elasticsans/arm-elasticsan/src/classic/* | New classic client operation interfaces and implementations |
| sdk/elasticsans/arm-elasticsan/src/api/* | New API layer with operations and context management |
| sdk/elasticsans/arm-elasticsan/samples/v2/* | Updated sample code for new API version and client structure |
| sdk/elasticsans/arm-elasticsan/samples/v1/* | Removed legacy v1 TypeScript samples |
| sdk/elasticsans/arm-elasticsan/api-extractor.json | Simplified configuration format |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
|
@yifanzhang let me know if your release is urgent and currently the release is blocked by some JS internal decisions. |
@MaryGao No it's not urgent. The release targets at 11/28 |
|
As the server rollout is running into some issues, we're not able to have the release now. |
This should not be unblocked now and we decided generating from swagger in Nov. |
Sure let's hold on this until service side is ready! |
|
have re-generated the code with generated swagger |
|
@MaryGao The server rollout is ready. Can we proceed with the release and target at the next release train by 2/27? Thanks! |
Configurations: 'specification/elasticsan/resource-manager/Microsoft.ElasticSan/ElasticSan/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: 'c86c7e36fb15171a9967d9fdc47784f2e4202ca6' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5515645 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=e1ca6d7f-4cb5-f011-bbd2-6045bd07ef68 Submitted by: yifanzhang@microsoft.com
Release Plan Details
Spec pull request: Stable version 2025-09-01 with prevalidation and autoscale changes azure-rest-api-specs#37218
Spec API version: 2025-09-01