Sync eng/common directory with azure-sdk-tools for PR 12532#36299
Merged
Sync eng/common directory with azure-sdk-tools for PR 12532#36299
Conversation
Change logging helpers to always write to host and either set color or use devops/gh formatting. We do not want to use Write-Error or Write-Warning directly because they can stop the script or not depending on preferences which makes it difficult to ensure local runs of scripts work the same as in the pipelines. So, we should never depend on these logging commands to cause a script to stop execution.
Removed legacy error handling for command failures.
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the eng/common directory with changes from azure-sdk-tools PR #12532, focusing on improving command execution error handling and logging behavior in PowerShell scripts.
Key changes:
- Standardized logging output methods to use
Write-Hostwith color formatting instead ofWrite-WarningandWrite-Error - Enhanced command invocation error handling with a new opt-out parameter for exit-on-failure behavior
- Simplified error handling logic by removing redundant CI-specific conditional checks
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/common/scripts/logging.ps1 | Replaced Write-Warning and Write-Error cmdlets with Write-Host using color parameters for consistent output formatting |
| eng/common/scripts/Helpers/CommandInvocation-Helpers.ps1 | Added DoNotExitOnFailedExitCode parameter, standardized $LASTEXITCODE variable casing, and streamlined error handling by removing CI-specific conditional logic |
weshaggard
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12532 See eng/common workflow