Sync eng/common directory with azure-sdk-tools for PR 12562 #36287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the eng/common directory with changes from azure-sdk-tools PR #12562, adding package type parameter support to API review scripts.
Key Changes:
- Added
packageTypeparameter to API review submission functions to track SDK type (e.g., client, mgmt, data-plane) - Updated function signatures and API calls to include the new package type information
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/scripts/Detect-Api-Changes.ps1 | Added packageType parameter extraction from packageInfo and passed it through Submit-Request function |
| eng/common/scripts/Create-APIReview.ps1 | Added packageType parameter to Upload-SourceArtifact and Upload-ReviewTokenFile functions, including multipart form data handling |
helen229
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12562 See eng/common workflow