Sync eng/common directory with azure-sdk-tools for PR 12478#36239
Merged
Sync eng/common directory with azure-sdk-tools for PR 12478#36239
Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes the eng/common directory with changes from azure-sdk-tools PR #12478. The primary purpose is to refactor package validation and DevOps work item management scripts by consolidating functionality and eliminating redundant script calls.
Key Changes:
- Consolidates
Validate-Package.ps1logic intoValidate-All-Packages.ps1as functions to avoid redundant authentication/validation checks - Converts
Update-DevOps-Release-WorkItem.ps1into a reusable function inDevOps-WorkItem-Helpers.ps1 - Adds support for direct
PackageInfoFilesparameter alongside existingArtifactListapproach
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
eng/common/scripts/Validate-All-Packages.ps1 |
Major refactoring: replaces script invocations with function calls, adds inline validation functions (ValidateChangeLog, VerifyAPIReview, IsVersionShipped, CreateUpdatePackageWorkItem), and adds support for PackageInfoFiles parameter |
eng/common/scripts/Prepare-Release.ps1 |
Updates to call Update-DevOpsReleaseWorkItem as a function instead of external script, changes error handling from $LASTEXITCODE to direct result check |
eng/common/scripts/Helpers/DevOps-WorkItem-Helpers.ps1 |
Adds global state management for authentication checks, implements CheckAzLoginAndDevOpsExtensionInstall and Update-DevOpsReleaseWorkItem functions to centralize DevOps interaction logic |
eng/common/pipelines/templates/steps/validate-all-packages.yml |
Converts parameters to typed format and adds PackageInfoFiles parameter support |
azure-sdk
force-pushed
the
sync-eng/common-users/raych1/update-validat-pkg-template-12478
branch
7 times, most recently
from
69b5f90 to
a30bce9
Compare
raych1
approved these changes
Oct 17, 2025
azure-sdk
force-pushed
the
sync-eng/common-users/raych1/update-validat-pkg-template-12478
branch
from
a30bce9 to
5180f4e
Compare
raych1
approved these changes
Oct 17, 2025
azure-sdk
deleted the
sync-eng/common-users/raych1/update-validat-pkg-template-12478
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12478 See eng/common workflow