Skip to content

[mgmt] deviceprovisioningservices release#36149

Merged
Siongithub merged 6 commits intoAzure:mainfrom
kazrael2119:deviceprovisioningservices
Oct 22, 2025
Merged

[mgmt] deviceprovisioningservices release#36149
Siongithub merged 6 commits intoAzure:mainfrom
kazrael2119:deviceprovisioningservices

Conversation

@kazrael2119
Copy link
Member

@kazrael2119 kazrael2119 commented Oct 9, 2025

Copilot AI review requested due to automatic review settings October 9, 2025 09:08
@kazrael2119 kazrael2119 requested review from a team, MaryGao, jeremymeng and qiaozha as code owners October 9, 2025 09:08
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Oct 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a management client release for deviceprovisioningservices, migrating from an AutoRest-generated SDK to a newer modular architecture based on TypeSpec specifications.

  • Migrates from legacy @azure/core-client based implementation to @azure-rest/core-client modular approach
  • Updates API to use new 2025-02-01-preview version with enhanced features like device registry namespaces
  • Restructures codebase with api/, classic/, and static-helpers/ directories for better organization

Reviewed Changes

Copilot reviewed 193 out of 195 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ci.mgmt.yml Adds branch exclusion for feature/v4
vitest.esm.config.ts Adds ESM test configuration
tsp-location.yaml Defines TypeSpec specification location
models/models.ts Complete rewrite with new model definitions and serializers
src/iotDpsClient.ts Modernizes client implementation to use new modular architecture
src/index.ts Updates exports to include new API surface and helper functions
test files Updates tests to use new synchronous operations and test configuration
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

sdk/deviceprovisioningservices/arm-deviceprovisioningservices/test/deviceprovisioningservices_operations_test.spec.ts:1

  • The test switches from asynchronous LRO operations (beginCreateOrUpdateAndWait, beginDeleteAndWait) to synchronous operations (createOrUpdate, delete) but still passes polling options to the delete operation. This suggests the operations may still be LROs but the test doesn't properly handle the returned pollers, potentially missing test coverage for the actual completion of these operations.
/*

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

@azure/arm-deviceprovisioningservices

@kazrael2119 kazrael2119 added the Self-Service Release PR for self-service release label Oct 16, 2025
@Siongithub
Copy link
Contributor

hi @MaryGao @qiaozha, gentle ping, could I get 1 more approval pls, if changes look okay? (Thank you!)

@Siongithub Siongithub enabled auto-merge (squash) October 21, 2025 11:57
@Siongithub Siongithub merged commit dfa5a07 into Azure:main Oct 22, 2025
13 checks passed
@kazrael2119 kazrael2119 deleted the deviceprovisioningservices branch October 23, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library. Self-Service Release PR for self-service release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants