[appconfiguration] Fix snippets generation #33885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpodwysocki
requested review from
HarshaNalluru and
minhanh-phan
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the snippet generation for the AppConfiguration package and updates the CHANGELOG to ignore snippet changes.
- Updated the README snippet to import and use the new KnownAppConfigAudience identifier.
- Added an ignore comment in the CHANGELOG to bypass snippet generation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/appconfiguration/app-configuration/README.md | Updated snippet code for correct audience import usage. |
| sdk/appconfiguration/app-configuration/CHANGELOG.md | Added dev-tool ignore comment for snippet generation. |
github-actions
bot
added
the
App Configuration
Collaborator
|
API change check API changes are not detected in this pull request. |
jeremymeng
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
Updates the snippets generation and adds an ignore to the CHANGELOG.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists