Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@azure/eventgrid] Update System events for EG Version 5.9.0 #32011

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

sarangan12
Copy link
Contributor

Packages impacted by this PR

@Azure/eventgrid

Issues associated with this PR

NA

Describe the problem that is addressed by this PR

This PR consists of the following changes:

  • Added new System Events:
    • Microsoft.ResourceNotifications.ContainerServiceEventResources.ScheduledEventEmitted
  • A new property policyRunSummary has been added to StorageLifecyclePolicyCompletedEventData interface.
  • New properties StorageLifecycleCompletionStatus and KnownStorageLifecycleCompletionStatus have been added.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

There are no specific/complex design scenarios for this task. It is a straightforward regenerate and some standard changes to the custom layer of the code.

Are there test cases added in this PR? (If not, why?)

No. This item is standard and we need not add test cases for every new events. The existing cases would be sufficient.

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

autorest --typescript swagger\README.md

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@sarangan12 sarangan12 requested review from bterlson and a team as code owners December 2, 2024 16:16
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure/eventgrid

@sarangan12 sarangan12 merged commit 1350c15 into Azure:main Dec 2, 2024
28 checks passed
sarangan12 added a commit that referenced this pull request Jan 21, 2025
### Packages impacted by this PR

`@azure/eventgrid`

### Issues associated with this PR

Azure/azure-rest-api-specs#32004

### Describe the problem that is addressed by this PR

This PR consists of the following changes:
- Added `internetMessageId` property to
`AcsEmailDeliveryReportReceivedEventData`.
- Added `recipientMailServerHostName` property to
`AcsEmailDeliveryReportStatusDetails`.
- For `AcsSmsReceivedEventData`:
  - Added `segmentCount` property
  - Made `message` & `receivedTimestamp` properties optional.

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?

There are no specific/complex design scenarios for this task. It is a
straightforward regenerate and some standard changes to the custom layer
of the code.

### Are there test cases added in this PR? _(If not, why?)_

No. This item is standard and we need not add test cases for every new
events. The existing cases would be sufficient.

### Provide a list of related PRs _(if any)_

- #28176 (This is the PR
that adds similar events to the SDK in the 5.1.0 release)
- #28513 (This is the PR
that adds similar events to the SDK in the 5.2.0 release)
- #28891 (This is the PR
that adds similar events to the SDK in the 5.3.0 release)
- #29035 (This is the PR
that adds similar events to the SDK in the 5.4.0 release)
- #29872 (This is the PR
that adds similar events to the SDK in the 5.5.0 release)
- #30811 (This is the PR
that adds similar events to the SDK in the 5.6.0 release)
- #32011 (This is the PR
that adds similar events to the SDK in the 5.9.0 release)

### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
```autorest --typescript swagger\README.md```

### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_
- [X] Added a changelog (if necessary)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants