[notification-hubs] Fix FCM notification

sdk/notificationhubs/notification-hubs/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Release History
 
+## 1.1.1 (2024-03-19)
+
+### Bugs Fixed
+
+- Fixed to allow `FcmV1Notification` as part of the `Notification` and `sendNotification` parameters.
+
 ## 1.1.0 (2024-03-01)
 
 ### Features Added

sdk/notificationhubs/notification-hubs/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@azure/notification-hubs",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "Azure Notification Hubs SDK for JavaScript",
   "sdk-type": "client",
   "main": "dist/index.cjs",
@@ -48,7 +48,7 @@
     "extract-api": "tsc -p . && api-extractor run --local",
     "format": "dev-tool run vendored prettier --write --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"",
     "integration-test:browser": "echo skipped",
-    "integration-test:node": "dev-tool run test:node-ts-input -- --timeout 600000 \"test/internal/**/*.spec.ts\" \"test/public/**/*.spec.ts\"",
+    "integration-test:node": "dev-tool run test:node-js-input -- --timeout 600000 \"dist-esm/test/internal/**/*.spec.js\" \"dist-esm/test/public/**/*.spec.js\"",
     "integration-test": "npm run integration-test:node && npm run integration-test:browser",
     "lint:fix": "eslint README.md package.json api-extractor.json src test --ext .ts,.javascript,.js --fix --fix-type [problem,suggestion]",
     "lint": "eslint README.md package.json api-extractor.json src test --ext .ts,.javascript,.js",
@@ -57,7 +57,7 @@
     "test:node": "npm run clean && tsc -p . && npm run integration-test:node",
     "test": "npm run clean && tsc -p . && npm run unit-test:node && npm run bundle && npm run unit-test:browser && npm run integration-test",
     "unit-test:browser": "karma start karma.conf.cjs --single-run",
-    "unit-test:node": "mocha --exclude  \"test/**/browser/*.spec.ts\" \"test/internal/unit/{,!(browser)/**/}*.spec.ts\" \"test/public/unit/{,!(browser)/**/}*.spec.ts\"",
+    "unit-test:node": "dev-tool run test:node-tsx-ts --no-test-proxy -- --exclude  \"test/**/browser/*.spec.ts\" \"test/internal/unit/{,!(browser)/**/}*.spec.ts\" \"test/public/unit/{,!(browser)/**/}*.spec.ts\"",
     "unit-test": "npm run unit-test:node && npm run unit-test:browser"
   },
   "files": [
@@ -94,11 +94,10 @@
     "@types/chai": "^4.3.1",
     "@types/mocha": "^10.0.0",
     "@types/node": "^18.0.0",
-    "c8": "^8.0.0",
+    "c8": "^9.1.0",
     "chai": "^4.3.10",
-    "dotenv": "^16.4.4",
-    "eslint": "^8.56.0",
-    "esm": "^3.2.25",
+    "dotenv": "^16.4.5",
+    "eslint": "^8.57.0",
     "karma": "^6.4.2",
     "karma-chrome-launcher": "^3.1.1",
     "karma-coverage": "^2.2.0",
@@ -113,20 +112,20 @@
     "mocha": "^10.0.0",
     "puppeteer": "^22.2.0",
     "rimraf": "^5.0.5",
-    "ts-node": "^10.9.2",
+    "tsx": "^4.7.1",
     "typescript": "~5.3.3"
   },
   "dependencies": {
-    "@azure/core-auth": "^1.6.0",
-    "@azure/abort-controller": "^2.0.0",
-    "@azure/core-lro": "^2.6.0",
-    "@azure/core-paging": "^1.5.0",
-    "@azure/core-rest-pipeline": "^1.14.0",
-    "@azure/core-tracing": "^1.0.1",
-    "@azure/core-util": "^1.7.0",
-    "@azure/core-xml": "^1.3.4",
-    "@azure/logger": "^1.0.4",
-    "@azure-rest/core-client": "^1.2.0",
+    "@azure/core-auth": "^1.7.0",
+    "@azure/abort-controller": "^2.1.0",
+    "@azure/core-lro": "^2.7.0",
+    "@azure/core-paging": "^1.6.0",
+    "@azure/core-rest-pipeline": "^1.15.0",
+    "@azure/core-tracing": "^1.1.0",
+    "@azure/core-util": "^1.8.0",
+    "@azure/core-xml": "^1.4.0",
+    "@azure/logger": "^1.1.0",
+    "@azure-rest/core-client": "^1.3.0",
     "tslib": "^2.6.2"
   }
 }

sdk/notificationhubs/notification-hubs/review/notification-hubs.api.md

@@ -775,7 +775,7 @@ export interface MpnsTemplateRegistrationDescriptionCommon extends MpnsRegistrat
 }
 
 // @public
-export type Notification = AppleNotification | AdmNotification | BaiduNotification | BrowserNotification | FcmLegacyNotification | XiaomiNotification | WindowsNotification | TemplateNotification;
+export type Notification = AppleNotification | AdmNotification | BaiduNotification | BrowserNotification | FcmLegacyNotification | FcmV1Notification | XiaomiNotification | WindowsNotification | TemplateNotification;
 
 // @public
 export interface NotificationCommon {

sdk/notificationhubs/notification-hubs/samples-dev/sendDirectNotification.fcmV1.ts

@@ -18,7 +18,7 @@ import * as dotenv from "dotenv";
 import {
   NotificationDetails,
   NotificationOutcomeState,
-  createFcmLegacyNotification,
+  createFcmV1Notification,
 } from "@azure/notification-hubs/models";
 import {
   NotificationHubsClientContext,
@@ -54,7 +54,7 @@ async function main(): Promise<void> {
 	}
 }`;
 
-  const notification = createFcmLegacyNotification({
+  const notification = createFcmV1Notification({
     body: messageBody,
   });
 

sdk/notificationhubs/notification-hubs/src/models/notification.ts

@@ -468,6 +468,7 @@ export type Notification =
   | BaiduNotification
   | BrowserNotification
   | FcmLegacyNotification
+  | FcmV1Notification
   | XiaomiNotification
   | WindowsNotification
   | TemplateNotification;

sdk/notificationhubs/notification-hubs/src/utils/constants.ts

@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-export const SDK_VERSION: string = "1.1.0";
+export const SDK_VERSION: string = "1.1.1";
 
 export const JSON_CONTENT_TYPE = "application/json;charset=utf-8";
 export const XML_CONTENT_TYPE = "application/xml";

sdk/notificationhubs/notification-hubs/tsconfig.json

@@ -10,8 +10,5 @@
     "moduleResolution": "NodeNext",
     "rootDir": "."
   },
-  "ts-node": {
-    "esm": true
-  },
   "include": ["src/**/*.ts", "test/**/*.ts", "samples-dev/**/*.ts"]
 }