[Service Bus] Add package.json to package (fixes #2857)#2892
Merged
Conversation
Contributor
|
But why.... |
Member
Author
|
When you compile a project that import's a JSON file, TypeScript will copy the json file into the output along with the other build artefacts. Otherwise relative imports are broken - note how src/index.ts gets built into dist/src/index.ts, so the path "../package.json" relative to index.ts would be broken unless TS copied it over for you. Basically, if you import a json file, TS treats it as a source file including emitting it into outDir. |
ramya-rao-a
approved these changes
May 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package.json is copied into the dist-esm folder but needs to be published as part of the package as well.