Skip to content

Deprecate baseurl and use endpoint instead for ts-http-runtime#28850

Merged
qiaozha merged 5 commits into
Azure:mainfrom
kazrael2119:use-endpoint
Mar 13, 2024
Merged

Deprecate baseurl and use endpoint instead for ts-http-runtime#28850
qiaozha merged 5 commits into
Azure:mainfrom
kazrael2119:use-endpoint

Conversation

@kazrael2119
Copy link
Copy Markdown
Member

@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@typespec/ts-http-runtime

Comment thread sdk/core/ts-http-runtime/CHANGELOG.md Outdated
Comment thread sdk/core/ts-http-runtime/src/client/urlHelpers.ts Outdated
Copy link
Copy Markdown
Member

@qiaozha qiaozha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

azure core client rest changes have been merged in #28236

@qiaozha
Copy link
Copy Markdown
Member

qiaozha commented Mar 12, 2024

if no more objection from you @timovv @joheredi, I will merge this PR tomorrow?

Comment thread sdk/core/ts-http-runtime/review/ts-http-runtime.api.md
Copy link
Copy Markdown
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiaozha qiaozha merged commit d561c63 into Azure:main Mar 13, 2024
@kazrael2119 kazrael2119 deleted the use-endpoint branch March 13, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use endpoint instead of baseUrl in RLC.

5 participants