[dev-tool] sample publish fix duplicate env vars in readme.md from samples#28771
Merged
Conversation
kazrael2119
requested review from
MaryGao,
ckairen,
deyaaeldeen,
mikeharder,
qiaozha,
witemple-msft and
xirzec
as code owners
github-actions
Bot
added
the
Mgmt
kazrael2119
commented
Mar 5, 2024
| @@ -1,246 +0,0 @@ | |||
| # client library samples for JavaScript | |||
Member
Author
There was a problem hiding this comment.
these changes is to remove old version samples
kazrael2119
changed the title
Collaborator
|
API change check API changes are not detected in this pull request. |
MaryGao
reviewed
Mar 5, 2024
| Alternatively, run a single sample with the correct environment variables set (setting up the `.env` file is not required if you do this), for example (cross-platform): | ||
|
|
||
| ```bash | ||
| npx cross-env NETAPP_SUBSCRIPTION_ID="<netapp subscription id>" NETAPP_RESOURCE_GROUP="<netapp resource group>" NETAPP_SUBSCRIPTION_ID="<netapp subscription id>" NETAPP_RESOURCE_GROUP="<netapp resource group>" node accountsCreateOrUpdateSample.js |
Member
There was a problem hiding this comment.
this file has this issue but the version is not the latest one so we just remove them.
MaryGao
reviewed
Mar 5, 2024
| function exampleNodeInvocation(info: SampleReadmeConfiguration) { | ||
| const firstModule = filterModules(info)[0]; | ||
| const envVars = firstModule.usedEnvironmentVariables | ||
| const envVars = [...new Set(firstModule.usedEnvironmentVariables)] |
Member
There was a problem hiding this comment.
@jeremymeng Could you help review this? The sample publish tools didn't handle the env vars duplications so we add this support.
MaryGao
changed the title
MaryGao
changed the title
MaryGao
changed the title
sample publish fix duplicate parameters in readme.md from samples
MaryGao
changed the title
sample publish fix duplicate parameters in readme.md from samplessample publish fix duplicate env vars in readme.md from samples
Merged
xirzec
approved these changes
Mar 6, 2024
Member
xirzec
left a comment
xirzec
left a comment
There was a problem hiding this comment.
Dev-tool changes look good to me, thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #28745