Skip to content

[Storage-Blob] Rename clients from *URL => *Client#2874

Merged
jeremymeng merged 2 commits into
Azure:feature/storagefrom
jeremymeng:rename-client
May 15, 2019
Merged

[Storage-Blob] Rename clients from *URL => *Client#2874
jeremymeng merged 2 commits into
Azure:feature/storagefrom
jeremymeng:rename-client

Conversation

@jeremymeng
Copy link
Copy Markdown
Member

No description provided.

@jeremymeng
Copy link
Copy Markdown
Member Author

/azp run azure-sdk-for-js - all-tests - storage-blob

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jeremymeng
Copy link
Copy Markdown
Member Author

/azp run azure-sdk-for-js - all-tests - storage-blob

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Member

@XiaoningLiu XiaoningLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, please make sure sample code in readme.md is good after code change.

@jeremymeng jeremymeng changed the title Rename clients from *URL => *Client [Storage-Blob] Rename clients from *URL => *Client May 14, 2019
@jeremymeng
Copy link
Copy Markdown
Member Author

/azp run azure-sdk-for-js - all-tests - storage-blob

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@XiaoningLiu
Copy link
Copy Markdown
Member

@jeremymeng Curious, what does "/azp run azure-sdk-for-js - all-tests - storage-blob" do?

@jeremymeng
Copy link
Copy Markdown
Member Author

"/azp run azure-sdk-for-js - all-tests - storage-blob" do?

@XiaoningLiu It manually trigger a azure devops build (see https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/github?view=azure-devops&tabs=yaml#comment-triggers). When I create this PR I didn't have PR validation enabled in that build pipeline so I used the comment to queue the build. Going forward it shouldn't be needed.

@jeremymeng jeremymeng merged commit 3325839 into Azure:feature/storage May 15, 2019
@jeremymeng jeremymeng deleted the rename-client branch May 15, 2019 03:44
@XiaoningLiu
Copy link
Copy Markdown
Member

Where do we define - all-tests - storage-blob parameters? Are they in some pipeline configurations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants