add @type/mocha in package.json#28422
Conversation
|
API change check API changes are not detected in this pull request. |
jeremymeng
left a comment
There was a problem hiding this comment.
Thanks for the fix! Do you know why the build started failing?
I don't know, but I will add this dependency in all the package.json in this pr |
@kazrael2119 we can merge this now to unblock js - core - ci pipeline, and update other packages later. |
|
I also opened a PR to revert my previous change which looks like it broke the build #28423 |
|
@jeremymeng should we merge this one or yours? |
we can merge this too as @types/mocha should be a dev dependency and not rely on other weird behaviors. But we can fix the rest of packages later. I will check whether codegen adds it properly. |
|
@kazrael2119 I will fix the rest of packages and merge into main directly to avoid triggering massive number of build pipelines |
No description provided.