[Service Bus] Skip unnecessary error in fromAmqpMessage#2824
Merged
Conversation
AlexGhiondea
approved these changes
May 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Offshoot from #2761
fromAmqpMessageis an helper method used by the library to convert a message received over an AMQP link to a type that we want to expose to our usersreceiveMessagesorregisterMessageHandlerpeekorreceiveDeferredMessagesWe currently throw an error when the input parameter to this helper method is not provided.
While these kind of parameter validations are helpful for user facing apis to validate user input, this particular check and error is an overkill for an internal function.
This PR removes the error being thrown and replaces it with an empty message.
This work is being done as part of #2658 where we are removing the errors that are not actionable by the user.