Skip to content

PR validation pipelines with Rush#2817

Merged
mitchdenny merged 15 commits into
Azure:masterfrom
mitchdenny:users/mitchdenny/pr-validation-pipelines
May 15, 2019
Merged

PR validation pipelines with Rush#2817
mitchdenny merged 15 commits into
Azure:masterfrom
mitchdenny:users/mitchdenny/pr-validation-pipelines

Conversation

@mitchdenny
Copy link
Copy Markdown
Contributor

This PR adds ci.yml files to each of our data-plane SDK folders (I think I got them all - based on Rush output). I've also added/updated a few .npmignore files to make sure that the ci.yml file doesn't get slurped into the NPM packages.

Once these are merged I'll run the pipegen tool over the repository to create all of the definitions.

@mitchdenny mitchdenny requested review from bsiegel and weshaggard May 10, 2019 22:57
Comment thread sdk/cosmosdb/cosmos/.npmignore Outdated
@bsiegel
Copy link
Copy Markdown
Member

bsiegel commented May 13, 2019

PackageName must be the full name of the package as declared in the package.json file, e.g. "@azure/service-bus"

@bsiegel
Copy link
Copy Markdown
Member

bsiegel commented May 13, 2019

We should also always pass --verbose to Rush commands, since by default, STDOUT output is suppressed.

Copy link
Copy Markdown
Member

@bsiegel bsiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Comment thread eng/pipelines/templates/jobs/archetype-sdk-client.yml Outdated
@mitchdenny
Copy link
Copy Markdown
Contributor Author

PackageName must be the full name of the package as declared in the package.json file, e.g. "@Azure/service-bus"

So at the moment I've got this working with the value being "storage-queue" (as an example). Is that not supposed to work, or does it produce a different result. More than happy to adjust it I just want to understand the difference in the two approaches :)

@bsiegel
Copy link
Copy Markdown
Member

bsiegel commented May 14, 2019

So at the moment I've got this working with the value being "storage-queue" (as an example). Is that not supposed to work, or does it produce a different result. More than happy to adjust it I just want to understand the difference in the two approaches :)

Huh, you're right it seems to work! The documentation is pretty clear that this should be the full package name as it is written in the package.json, but for some reason it seems to work without the @org/ prefix. I'd suggest we stick to the documented format, just in case this is a bug that is eventually fixed.

@mitchdenny mitchdenny requested a review from bsiegel May 14, 2019 22:31
Copy link
Copy Markdown
Member

@bsiegel bsiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small tweaks

Comment thread eng/pipelines/templates/jobs/archetype-sdk-client.yml Outdated
Comment thread eng/pipelines/templates/jobs/archetype-sdk-client.yml Outdated
@mitchdenny
Copy link
Copy Markdown
Contributor Author

Just a couple small tweaks

Done - just waiting for the builds to finish and then I think its there.

@mitchdenny mitchdenny self-assigned this May 15, 2019
@mitchdenny mitchdenny requested a review from bsiegel May 15, 2019 16:58
Copy link
Copy Markdown
Member

@bsiegel bsiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍✨Ship It✨:shipit:

Note: Please pull latest master and rebase this branch onto it before merging this pull request.

$ git checkout master
$ git pull origin master

$ git checkout -
$ git rebase master

$ git push -f

@mitchdenny mitchdenny force-pushed the users/mitchdenny/pr-validation-pipelines branch from 7f506eb to 995b151 Compare May 15, 2019 18:22
@mitchdenny mitchdenny merged commit 696ab11 into Azure:master May 15, 2019
@mitchdenny mitchdenny deleted the users/mitchdenny/pr-validation-pipelines branch May 15, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants