PR validation pipelines with Rush#2817
Conversation
|
|
|
We should also always pass |
So at the moment I've got this working with the value being "storage-queue" (as an example). Is that not supposed to work, or does it produce a different result. More than happy to adjust it I just want to understand the difference in the two approaches :) |
Huh, you're right it seems to work! The documentation is pretty clear that this should be the full package name as it is written in the package.json, but for some reason it seems to work without the @org/ prefix. I'd suggest we stick to the documented format, just in case this is a bug that is eventually fixed. |
Done - just waiting for the builds to finish and then I think its there. |
bsiegel
left a comment
There was a problem hiding this comment.
👍✨Ship It✨![]()
Note: Please pull latest master and rebase this branch onto it before merging this pull request.
$ git checkout master
$ git pull origin master
$ git checkout -
$ git rebase master
$ git push -f7f506eb to
995b151
Compare
This PR adds
ci.ymlfiles to each of our data-plane SDK folders (I think I got them all - based on Rush output). I've also added/updated a few.npmignorefiles to make sure that theci.ymlfile doesn't get slurped into the NPM packages.Once these are merged I'll run the
pipegentool over the repository to create all of the definitions.