Skip to content

[dev-tool][customization] fix duplicate file header#27610

Merged
jeremymeng merged 3 commits intoAzure:mainfrom
jeremymeng:devtool/dupe-headers
Oct 31, 2023
Merged

[dev-tool][customization] fix duplicate file header#27610
jeremymeng merged 3 commits intoAzure:mainfrom
jeremymeng:devtool/dupe-headers

Conversation

@jeremymeng
Copy link
Member

@jeremymeng jeremymeng commented Oct 31, 2023

There are two trailing whitespaces in the header template. However after we customize, we run format so the whitespaces are removed. That would fail the check of whether the header already exists. This PR removes the trailing whitespaces thus after formatting the header still matches the template.

Issue #26741

@github-actions github-actions bot added the EngSys This issue is impacting the engineering system. label Oct 31, 2023
Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeremymeng jeremymeng enabled auto-merge (squash) October 31, 2023 19:25
@jeremymeng
Copy link
Member Author

/check-enforcer override

@jeremymeng jeremymeng merged commit 54c6760 into Azure:main Oct 31, 2023
@jeremymeng jeremymeng deleted the devtool/dupe-headers branch October 31, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants