Skip to content

[mgmt] mobilenetwork release#27604

Merged
qiaozha merged 10 commits intoAzure:mainfrom
kazrael2119:mobilenetwork-re
Nov 28, 2023
Merged

[mgmt] mobilenetwork release#27604
qiaozha merged 10 commits intoAzure:mainfrom
kazrael2119:mobilenetwork-re

Conversation

@kazrael2119
Copy link
Member

@kazrael2119 kazrael2119 commented Oct 31, 2023

@kazrael2119 kazrael2119 changed the title Mobilenetwork re [mgmt] mobilenetwork release Oct 31, 2023
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 31, 2023

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-arm-mobilenetwork

qiaozha
qiaozha reviewed Nov 20, 2023
View reviewed changes
sdk/mobilenetwork/arm-mobilenetwork/src/models/mappers.ts
constraints: {
InclusiveMaximum: 4294967295,
InclusiveMinimum: 0
InclusiveMinimum: 1000
Copy link
Member

@qiaozha qiaozha Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel like this is a breaking change. because what used to work like under 1000 but not now.

Copy link
Member Author

@kazrael2119 kazrael2119 Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is approved in api level Azure/azure-rest-api-specs#26133 (comment)

Copy link
Member

@qiaozha qiaozha Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should bump major version here.

Copy link

@andrew-lee-1089 andrew-lee-1089 Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never released PacketCapture in the old API, so we are safe to release without a major bump.

Copy link
Member Author

@kazrael2119 kazrael2119 Nov 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the last release version is 2023-06-01 which contains PacketCapture, so I think we should bump a major version
last release request: https://github.com/Azure/sdk-release-request/issues/4278

@qiaozha qiaozha merged commit 2e18428 into Azure:main Nov 28, 2023
@kazrael2119 kazrael2119 deleted the mobilenetwork-re branch November 28, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiaozha qiaozha qiaozha approved these changes

@ckairen ckairen Awaiting requested review from ckairen

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen deyaaeldeen is a code owner

@jeremymeng jeremymeng Awaiting requested review from jeremymeng jeremymeng is a code owner

@bterlson bterlson Awaiting requested review from bterlson

@xirzec xirzec Awaiting requested review from xirzec xirzec is a code owner

@jsquire jsquire Awaiting requested review from jsquire

@ronniegeraghty ronniegeraghty Awaiting requested review from ronniegeraghty

@witemple-msft witemple-msft Awaiting requested review from witemple-msft

+1 more reviewer

@andrew-lee-1089 andrew-lee-1089 andrew-lee-1089 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kazrael2119 @azure-sdk @andrew-lee-1089 @qiaozha