Add defender easm sdk by thang-bit · Pull Request #27256 · Azure/azure-sdk-for-js

thang-bit · 2023-09-26T22:18:59Z

product documentation
Azure/azure-sdk#5062
Typespec PR: Azure/azure-rest-api-specs#24937
arcboard: Azure/azure-sdk#5062
apiview: https://apiview.dev/Assemblies/Review/03ef0c5f65374c3789d8302ef5c9c570

Packages impacted by this PR

Issues associated with this PR

Azure SDK Review issue: https://github.com/Azure/azure-sdk-pr/issues/1276
Azure SDK Introducing issue: Azure/azure-sdk#5062

Describe the problem that is addressed by this PR

Adding a new JavaScript data-plane sdk for EASM service

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Yes, test cases are added

Provide a list of related PRs (if any)

Previous PR: Azure Defender EASM Public Preview #26755. It was closed because Shad is no longer working for Microsoft and other developers don't have access to push to that PR.

Command used to generate this PR:***(Applicable only to SDK release request PRs)*

Used npx tsp complile to generate the PR

Checklists

Added impacted package name to the issue description
Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
Added a changelog (if necessary)

thang-bit · 2023-09-26T22:27:51Z

@xirzec, I have moved PR: #26755 to this PR

thang-bit · 2023-10-02T15:45:34Z

Hi Team, can someone review this PR whenever they have time?

API view: https://apiview.dev/Assemblies/Review/03ef0c5f65374c3789d8302ef5c9c570

This is the link to the review meeting: https://microsoft-my.sharepoint.com/:v:/p/teglaza/Ecjz9icYN6VPgF2ggPn3YEIBOXcWkxKGMQuvSPwHpc4nxg

cc: @joheredi @xirzec

…ord tests again to get browser tests results

…into easm-js-sdk

sdk/easm/defender-easm-rest/package.json

jeremymeng

Added some comments.

We shouldn't be adding recordings into this repo, and should use the latest workflow instead, unless there's anything I am missing about rest clients.

https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/test-utils/recorder/ASSET_SYNC_MIGRATION.md

sdk/easm/defender-easm-rest/README.md

sdk/easm/defender-easm-rest/package.json

sdk/easm/defender-easm-rest/samples-dev/discoTemplateSample.ts

SUBSCRIPTIONID to SUBSCRIPTION_ID to readability Update README, so the sample links point to future actual link

Update assets.json to reference to the pushed tests

…into easm-js-sdk

jeremymeng

Looks good other than two more nit comments

sdk/easm/defender-easm-rest/samples-dev/discoTemplateSample.ts

…into easm-js-sdk Resolve merge conflict Update environments names in samples files

thang-bit · 2023-10-16T21:07:46Z

@jeremymeng would this PR be merged automatically? Or will it be manually merged by the reviewers

jeremymeng · 2023-10-16T21:15:27Z

@thang-bit as a maintainer you should request write permission per instruction here https://eng.ms/docs/products/azure-developer-experience/onboard/access?tabs=write-access

Add easm sdk

5d56f97

thang-bit requested review from bterlson, deyaaeldeen, jeremymeng, witemple-msft and xirzec as code owners September 26, 2023 22:18

thang-bit requested review from ckairen and mikeharder as code owners October 2, 2023 18:56

thang-bit force-pushed the easm-js-sdk branch from 759e526 to 5d56f97 Compare October 2, 2023 21:36

thang-bit added 11 commits October 2, 2023 22:41

Update rush.json, regenerate sdk, and re-add tests

59333b3

Add tests, recordings and update package.json

ff1bfaf

Add samples and pnpm-lock.yaml

7045044

Update broken links in README.md

93d4fda

Update karma.conf.js to load env variables for browser tests. Run rec…

91b8457

…ord tests again to get browser tests results

Update package.json for defende-easm-rest project

9bd0a02

Update dependencies and pnpm-lock.yaml

1a8e0a5

Merge branch 'main' of https://github.com/thang-bit/azure-sdk-for-js …

1df4c74

…into easm-js-sdk

Generate samples

a489a78

run format and lint

5b8a3bd

Remove en-us locale from the link

a06796a

deyaaeldeen reviewed Oct 11, 2023

View reviewed changes

sdk/easm/defender-easm-rest/package.json Outdated Show resolved Hide resolved

jeremymeng reviewed Oct 11, 2023

View reviewed changes

Update package.json to require the minimum node 16

0cf739b

SUBSCRIPTIONID to SUBSCRIPTION_ID to readability Update README, so the sample links point to future actual link

thang-bit requested review from deyaaeldeen and jeremymeng October 13, 2023 02:46

thang-bit added 3 commits October 15, 2023 20:38

Remove recordings and commit them to assets-sdk repo instead

b551aa1

Update assets.json to reference to the pushed tests

Merge branch 'main' of https://github.com/thang-bit/azure-sdk-for-js …

194f598

…into easm-js-sdk

Update pnpm-lock.yaml to add easm dependencies

ecafee9

jeremymeng approved these changes Oct 16, 2023

View reviewed changes

sdk/easm/defender-easm-rest/samples-dev/discoTemplateSample.ts Outdated Show resolved Hide resolved

sdk/easm/defender-easm-rest/samples-dev/discoTemplateSample.ts Outdated Show resolved Hide resolved

Merge branch 'main' of https://github.com/thang-bit/azure-sdk-for-js …

c783234

…into easm-js-sdk Resolve merge conflict Update environments names in samples files

jeremymeng merged commit b00a93b into Azure:main Oct 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add defender easm sdk#27256

Add defender easm sdk#27256
jeremymeng merged 17 commits intoAzure:mainfrom
thang-bit:easm-js-sdk

thang-bit commented Sep 26, 2023 •

edited

Loading

Uh oh!

thang-bit commented Sep 26, 2023

Uh oh!

thang-bit commented Oct 2, 2023 •

edited

Loading

Uh oh!

Uh oh!

jeremymeng left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeremymeng left a comment

Uh oh!

Uh oh!

Uh oh!

thang-bit commented Oct 16, 2023

Uh oh!

jeremymeng commented Oct 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

thang-bit commented Sep 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Packages impacted by this PR

Issues associated with this PR

Describe the problem that is addressed by this PR

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

Uh oh!

thang-bit commented Sep 26, 2023

Uh oh!

thang-bit commented Oct 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jeremymeng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeremymeng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thang-bit commented Oct 16, 2023

Uh oh!

jeremymeng commented Oct 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

thang-bit commented Sep 26, 2023 •

edited

Loading

Command used to generate this PR:***(Applicable only to SDK release request PRs)*

thang-bit commented Oct 2, 2023 •

edited

Loading