fix: communication-sms: remove mocha arrow functions#26659
Merged
jeremymeng merged 2 commits intoAzure:mainfrom Jul 28, 2023
Merged
Conversation
StevanFreeborn
requested review from
gfeitosa-msft,
ilyapaliakou-msft,
ozgurcivi-msft and
phermanov-msft
as code owners
github-actions
bot
added
Communication - SMS
Community Contribution
|
Thank you for your contribution @StevanFreeborn! We will review the pull request and get back to you soon. |
jeremymeng
approved these changes
Jul 28, 2023
Member
jeremymeng
left a comment
jeremymeng
left a comment
There was a problem hiding this comment.
@StevanFreeborn thanks a lot for your fix!
StevanFreeborn
deleted the
stevanfreeborn/fix/comm-sms-remove-mocha-arrow-functions
branch
dgetu
pushed a commit
that referenced
this pull request
Sep 6, 2023
### Packages impacted by this PR `sdk\communication\communication-sms` ### Issues associated with this PR #13005 ### Describe the problem that is addressed by this PR The existing mocha tests for the `sdk\communication\communication-sms` made use of the arrow syntax for callback functions. Mocha recommends not to do this because you lose access to the mocha context (https://mochajs.org/#arrow-functions). ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? The reason for utilizing the function keyword instead of an arrow syntax to write the callback functions in these mocha tests is to maintain access to the mocha context. ### Are there test cases added in this PR? _(If not, why?)_ No additional test cases were added in this PR as the change only required modifying existing test cases. ### Provide a list of related PRs _(if any)_ #23761 - Same fix, but for the `sdk\search\search-documents` package #23789 - Same fix but for the `sdk\attestation\attestation` package #23835 - Same fix but for the `sdk\batch\batch` package #23850 - Same fix but for the `sdk\cognitivelanguage\ai-language-conversations` package #23881 - Same fix but for the `sdk\cognitiveservices\cognitiveservices-luis-authoring` package #24126 - Same fix but for the `sdk\cognitiveservices\cognitiveservices-luis-runtime` package #21470 - Same fix but for the `sdk\communication\communication-chat` package #24746 - Same fix but for the `sdk\communication\communication-common` package #24747 - Same fix but for the `sdk\communication\communication-email` package #24797 - Same fix but for the `sdk\communication\communication-identity` package #24800 - Same fix but for the `sdk\communication\communication-rooms` package #24865 - Same fix but for the `sdk\communication\communication-job-router` package #25148 - Same fix but for the `sdk\confidentialledger\confidential-ledger-rest` package ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ **_Not applicable_** ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
sdk\communication\communication-smsIssues associated with this PR
#13005
Describe the problem that is addressed by this PR
The existing mocha tests for the
sdk\communication\communication-smsmade use of the arrow syntax for callback functions. Mocha recommends not to do this because you lose access to the mocha context (https://mochajs.org/#arrow-functions).What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
The reason for utilizing the function keyword instead of an arrow syntax to write the callback functions in these mocha tests is to maintain access to the mocha context.
Are there test cases added in this PR? (If not, why?)
No additional test cases were added in this PR as the change only required modifying existing test cases.
Provide a list of related PRs (if any)
#23761 - Same fix, but for the
sdk\search\search-documentspackage#23789 - Same fix but for the
sdk\attestation\attestationpackage#23835 - Same fix but for the
sdk\batch\batchpackage#23850 - Same fix but for the
sdk\cognitivelanguage\ai-language-conversationspackage#23881 - Same fix but for the
sdk\cognitiveservices\cognitiveservices-luis-authoringpackage#24126 - Same fix but for the
sdk\cognitiveservices\cognitiveservices-luis-runtimepackage#21470 - Same fix but for the
sdk\communication\communication-chatpackage#24746 - Same fix but for the
sdk\communication\communication-commonpackage#24747 - Same fix but for the
sdk\communication\communication-emailpackage#24797 - Same fix but for the
sdk\communication\communication-identitypackage#24800 - Same fix but for the
sdk\communication\communication-roomspackage#24865 - Same fix but for the
sdk\communication\communication-job-routerpackage#25148 - Same fix but for the
sdk\confidentialledger\confidential-ledger-restpackageCommand used to generate this PR:**(Applicable only to SDK release request PRs)
Not applicable
Checklists