Skip to content

[Service Bus] Fix NYC code coverage breaking changes in 14.0.0#2627

Merged
HarshaNalluru merged 1 commit into
Azure:masterfrom
HarshaNalluru:FixNYC
May 1, 2019
Merged

[Service Bus] Fix NYC code coverage breaking changes in 14.0.0#2627
HarshaNalluru merged 1 commit into
Azure:masterfrom
HarshaNalluru:FixNYC

Conversation

@HarshaNalluru
Copy link
Copy Markdown
Contributor

@mikeharder
This PR attempts to fix improper functioning of nyc
nyc code coverage is not working after the update from ^13.3.0 to ^14.0.0 [ #2270 ]

[Breaking Change in 14.0.0]
https://github.com/istanbuljs/nyc/blob/master/CHANGELOG.md
https://github.com/istanbuljs/nyc#source-map-support-for-pre-instrumented-codebases

More reference - #2297 (comment)

@HarshaNalluru HarshaNalluru self-assigned this May 1, 2019
@HarshaNalluru HarshaNalluru added the Client This issue points to a problem in the data-plane of the library. label May 1, 2019
@HarshaNalluru HarshaNalluru merged commit 95b5e70 into Azure:master May 1, 2019
@ramya-rao-a
Copy link
Copy Markdown
Contributor

@HarshaNalluru Good find!
Can you update the nyc usage that is done in storage, event hubs, eph and amqp-common as well?

@HarshaNalluru
Copy link
Copy Markdown
Contributor Author

For storage, I'm doing it as part of my PR for Rollup (waiting for review #2297).
I can make PR for the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. Service Bus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants