Skip to content

[Storage] Update live test command for storage packages#2616

Merged
HarshaNalluru merged 4 commits into
Azure:masterfrom
HarshaNalluru:UpdateTestCommand
May 2, 2019
Merged

[Storage] Update live test command for storage packages#2616
HarshaNalluru merged 4 commits into
Azure:masterfrom
HarshaNalluru:UpdateTestCommand

Conversation

@HarshaNalluru
Copy link
Copy Markdown
Contributor

@HarshaNalluru HarshaNalluru commented May 1, 2019

@bsiegel

In #2047 - 128c033,

image
is updated to
image


Description

  • Nightly tests for storage-packages failed because build:test command wasn't executed.
  • This PR attempts to fix the nightly test runs by updating the "unit-browser" command to include "build:test".
  • [Storage] Rollup for tests in storage #2297 involves rollup for the tests in storage-packages, I will be updating the "scripts" section in the package.json to stay more consistent with the current package.json of servicebus/eventhubs(either in the same PR or in a follow-up PR).

@HarshaNalluru HarshaNalluru self-assigned this May 1, 2019
@HarshaNalluru HarshaNalluru added the Storage Storage Service (Queues, Blobs, Files) label May 1, 2019
@bsiegel
Copy link
Copy Markdown
Member

bsiegel commented May 1, 2019

This is fine for now - I am refactoring how the test commands are split out in a PR right now though, and once we have that landed it will fix this problem.

Copy link
Copy Markdown
Member

@bsiegel bsiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍✨Ship It✨:shipit:

@HarshaNalluru HarshaNalluru merged commit 6d48236 into Azure:master May 2, 2019
@HarshaNalluru HarshaNalluru deleted the UpdateTestCommand branch May 2, 2019 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants