[core-rest-pipeline] Remove oscpu from OS sniffing#24809
Merged
mpodwysocki merged 2 commits intomainfrom Feb 9, 2023
Merged
Conversation
Collaborator
|
API change check API changes are not detected in this pull request. |
Member
|
Could you post an example UA before/after this change from Chrome, Edge, and Firefox? |
witemple-msft
approved these changes
Feb 9, 2023
Member
witemple-msft
left a comment
There was a problem hiding this comment.
This may change the formatting of some platform specific strings (like UA we send), but they'll contain the same basic info.
Contributor
Author
|
@xirzec Note that this change will affect Blink-Based browsers with Chrome/Edge/Opera. Note that Safari and Firefox do not implement the Before with
After using Blink Based Browsers (Chrome/Edge/Opera/etc) with
|
xirzec
approved these changes
Feb 9, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
#24758
Describe the problem that is addressed by this PR
Relies on the deprecated
oscpu. This uses the non-standardglobalThis.navigator.userAgentData.platformand falls back to the deprecatedglobalThis.navigator.platform.What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
We could have removed the OS checks overall, but we can get better telemetry to keep the OS detection.
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists