Conversation
ghost
added
the
jeremymeng
left a comment
jeremymeng
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the improvement!
|
API change check API changes are not detected in this pull request. |
xirzec
left a comment
xirzec
left a comment
There was a problem hiding this comment.
I love when the red subtraction number is bigger than the green addition number.
sdk/core/core-util/src/delay.ts
Outdated
| let timer: ReturnType<typeof setTimeout> | undefined = undefined; | ||
| let onAborted: (() => void) | undefined = undefined; | ||
|
|
||
| const rejectOnAbort = (): void => { |
There was a problem hiding this comment.
since we're cleaning this up, it might be nicer to have these simply be named functions instead of anonymous ones bound to a local const:
function rejectOnAbort() {| import { isDefined } from "./typeGuards"; | ||
|
|
||
| const StandardAbortMessage = "The operation was aborted."; | ||
| const StandardAbortMessage = "The delay was aborted."; |
There was a problem hiding this comment.
I think some Storage tests at least might be sniffing the message, so you could see some failures with brittle tests. I tried to clean most of that up recently, but fair warning. :)
There was a problem hiding this comment.
The packages in the CI pipeline seem to be happy but if you come across any such failure, please pass it my way and I will address it.
4 participants
Minor edit to use modern syntax and simpler control flow.