Skip to content

fix: comm-chat: remove mocha arrow functions #24127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremymeng merged 1 commit into from
Feb 14, 2023
Merged

fix: comm-chat: remove mocha arrow functions #24127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sdk/communication/communication-chat/test/internal/chatClient.mocked.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,18 @@ import {

const API_VERSION = apiVersion.mapper.defaultValue;

describe("[Mocked] ChatClient", async () => {
describe("[Mocked] ChatClient", async function () {
let chatClient: ChatClient;

afterEach(() => {
afterEach(function () {
sinon.restore();
});

it("can instantiate", async () => {
it("can instantiate", async function () {
new ChatClient(baseUri, new AzureCommunicationTokenCredential(generateToken()));
});

it("makes successful create thread request", async () => {
it("makes successful create thread request", async function () {
const mockHttpClient = generateHttpClient(201, mockCreateThreadResult);

chatClient = createChatClient(mockHttpClient);
Expand Down Expand Up @@ -63,7 +63,7 @@ describe("[Mocked] ChatClient", async () => {
assert.isNotEmpty(request.headers.get("repeatability-request-id"));
});

it("makes successful list threads request", async () => {
it("makes successful list threads request", async function () {
const mockResponse: RestModel.ChatThreadsItemCollection = {
value: [mockThreadItem, mockThreadItem],
};
Expand All @@ -87,7 +87,7 @@ describe("[Mocked] ChatClient", async () => {
assert.equal(request.method, "GET");
});

it("makes successful delete thread request", async () => {
it("makes successful delete thread request", async function () {
const mockHttpClient = generateHttpClient(204);
chatClient = createChatClient(mockHttpClient);
const spy = sinon.spy(mockHttpClient, "sendRequest");
Expand Down
36 changes: 18 additions & 18 deletions sdk/communication/communication-chat/test/internal/chatThreadClient.mocked.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,19 +29,19 @@ import {

const API_VERSION = apiVersion.mapper.defaultValue;

describe("[Mocked] ChatThreadClient", async () => {
describe("[Mocked] ChatThreadClient", async function () {
const threadId: string = "threadId";
let chatThreadClient: ChatThreadClient;

afterEach(() => {
afterEach(function () {
sinon.restore();
});

it("can instantiate", async () => {
it("can instantiate", async function () {
new ChatThreadClient(threadId, baseUri, new AzureCommunicationTokenCredential(generateToken()));
});

it("makes successful get properties request", async () => {
it("makes successful get properties request", async function () {
const mockHttpClient = generateHttpClient(200, mockThread);
chatThreadClient = createChatThreadClient(mockThread.id, mockHttpClient);

Expand All @@ -68,7 +68,7 @@ describe("[Mocked] ChatThreadClient", async () => {
assert.equal(request.method, "GET");
});

it("makes successful update thread topic", async () => {
it("makes successful update thread topic", async function () {
const mockHttpClient = generateHttpClient(204);
chatThreadClient = createChatThreadClient(threadId, mockHttpClient);

Expand All @@ -85,7 +85,7 @@ describe("[Mocked] ChatThreadClient", async () => {
assert.deepEqual(JSON.parse(request.body as string), { topic: topic });
});

it("makes successful send message request", async () => {
it("makes successful send message request", async function () {
const mockHttpClient = generateHttpClient(201, {
id: mockMessage.id,
});
Expand Down Expand Up @@ -119,7 +119,7 @@ describe("[Mocked] ChatThreadClient", async () => {
});
});

it("makes successful get message request", async () => {
it("makes successful get message request", async function () {
const mockHttpClient = generateHttpClient(200, mockMessage);
chatThreadClient = createChatThreadClient(threadId, mockHttpClient);
const spy = sinon.spy(mockHttpClient, "sendRequest");
Expand Down Expand Up @@ -155,7 +155,7 @@ describe("[Mocked] ChatThreadClient", async () => {
assert.equal(request.method, "GET");
});

it("makes successful list messages request", async () => {
it("makes successful list messages request", async function () {
const { senderCommunicationIdentifier, ...rest } = mockMessage;

const mockResponse: RestModel.ChatMessagesCollection = {
Expand Down Expand Up @@ -205,7 +205,7 @@ describe("[Mocked] ChatThreadClient", async () => {
assert.equal(request.method, "GET");
});

it("makes successful update message request", async () => {
it("makes successful update message request", async function () {
const mockHttpClient = generateHttpClient(204);
chatThreadClient = createChatThreadClient(threadId, mockHttpClient);
const spy = sinon.spy(mockHttpClient, "sendRequest");
Expand All @@ -230,7 +230,7 @@ describe("[Mocked] ChatThreadClient", async () => {
});
});

it("makes successful delete message request", async () => {
it("makes successful delete message request", async function () {
const mockHttpClient = generateHttpClient(204);
chatThreadClient = createChatThreadClient(threadId, mockHttpClient);
const spy = sinon.spy(mockHttpClient, "sendRequest");
Expand All @@ -246,7 +246,7 @@ describe("[Mocked] ChatThreadClient", async () => {
assert.equal(request.method, "DELETE");
});

it("makes successful add chat participants request", async () => {
it("makes successful add chat participants request", async function () {
const mockHttpClient = generateHttpClient(201);
chatThreadClient = createChatThreadClient(threadId, mockHttpClient);
const spy = sinon.spy(mockHttpClient, "sendRequest");
Expand Down Expand Up @@ -277,7 +277,7 @@ describe("[Mocked] ChatThreadClient", async () => {
);
});

it("makes successful list chat participants request", async () => {
it("makes successful list chat participants request", async function () {
const mockHttpClient = generateHttpClient(200, {
value: [mockParticipant],
});
Expand Down Expand Up @@ -309,7 +309,7 @@ describe("[Mocked] ChatThreadClient", async () => {
assert.equal(request.method, "GET");
});

it("makes successful remove chat participant request", async () => {
it("makes successful remove chat participant request", async function () {
const mockHttpClient = generateHttpClient(204);
chatThreadClient = createChatThreadClient(threadId, mockHttpClient);
const spy = sinon.spy(mockHttpClient, "sendRequest");
Expand All @@ -327,7 +327,7 @@ describe("[Mocked] ChatThreadClient", async () => {
assert.deepEqual(mockParticipant.communicationIdentifier, requestJson);
});

it("makes successful sent typing notification request", async () => {
it("makes successful sent typing notification request", async function () {
const mockHttpClient = generateHttpClient(200);
chatThreadClient = createChatThreadClient(threadId, mockHttpClient);
const spy = sinon.spy(mockHttpClient, "sendRequest");
Expand All @@ -344,7 +344,7 @@ describe("[Mocked] ChatThreadClient", async () => {
assert.equal(request.method, "POST");
});

it("makes only one sent typing notification request within 8 secs", async () => {
it("makes only one sent typing notification request within 8 secs", async function () {
const mockHttpClient = generateHttpClient(400);
chatThreadClient = createChatThreadClient(threadId, mockHttpClient);
const spy = sinon.spy(mockHttpClient, "sendRequest");
Expand All @@ -368,7 +368,7 @@ describe("[Mocked] ChatThreadClient", async () => {
}
});

it("makes successful sent typing notification request with sender display name", async () => {
it("makes successful sent typing notification request with sender display name", async function () {
const mockHttpClient = generateHttpClient(200);
chatThreadClient = createChatThreadClient(threadId, mockHttpClient);
const spy = sinon.spy(mockHttpClient, "sendRequest");
Expand All @@ -387,7 +387,7 @@ describe("[Mocked] ChatThreadClient", async () => {
assert.deepEqual(JSON.parse(request.body as string), options);
});

it("makes successful sent read receipt request", async () => {
it("makes successful sent read receipt request", async function () {
const mockHttpClient = generateHttpClient(200);
chatThreadClient = createChatThreadClient(threadId, mockHttpClient);
const spy = sinon.spy(mockHttpClient, "sendRequest");
Expand All @@ -403,7 +403,7 @@ describe("[Mocked] ChatThreadClient", async () => {
assert.equal(request.method, "POST");
});

it("makes successful list read receipts request", async () => {
it("makes successful list read receipts request", async function () {
const mockHttpClient = generateHttpClient(200, {
value: [mockChatMessageReadReceipt, mockChatMessageReadReceipt],
});
Expand Down