Skip to content

cdn release#23887

Merged
MaryGao merged 10 commits intoAzure:mainfrom
kazrael2119:cdn-refresh
Dec 20, 2022
Merged

cdn release#23887
MaryGao merged 10 commits intoAzure:mainfrom
kazrael2119:cdn-refresh

Conversation

@kazrael2119
Copy link
Copy Markdown
Member

@kazrael2119 kazrael2119 commented Nov 17, 2022

@ghost ghost added the Mgmt This issue is related to a management-plane library. label Nov 17, 2022
Copy link
Copy Markdown
Member

@lirenhe lirenhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't quite understand the breaking, can we use the same commit of the Swagger for the exsiting SDK instead of the latest one to avoid breaking change?

@kazrael2119 kazrael2119 changed the title cdn refresh cdn release Dec 8, 2022
@MaryGao
Copy link
Copy Markdown
Member

MaryGao commented Dec 13, 2022

It is that the old commit id does not work so we take the latest one

Don't quite understand the breaking, can we use the same commit of the Swagger for the exsiting SDK instead of the latest one to avoid breaking change?

Because the old commit id does not work so we take the latest one

@lirenhe
Copy link
Copy Markdown
Member

lirenhe commented Dec 14, 2022

It is that the old commit id does not work so we take the latest one

Don't quite understand the breaking, can we use the same commit of the Swagger for the exsiting SDK instead of the latest one to avoid breaking change?

Because the old commit id does not work so we take the latest one

My understanding is by default we should use the old commit id to avoid breaking change, is it possbile to investigate why the old one does not work instead of using the latest one directly, especially the latest one contains breaking change.

cc @xboxeer , @qiaozha

@MaryGao MaryGao self-requested a review December 16, 2022 07:39
resourceGroupName,
profileName,
endpointName,
customDomainName,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to revert these changes


// #endregion

// Operation Specifications
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kazrael2119 kazrael2119 requested a review from ckairen as a code owner December 19, 2022 08:11
@MaryGao MaryGao self-requested a review December 20, 2022 07:31
Copy link
Copy Markdown
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaryGao MaryGao merged commit 3e79f2a into Azure:main Dec 20, 2022
@kazrael2119 kazrael2119 deleted the cdn-refresh branch February 14, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants