Skip to content

[Maps] Onboarding @azure-rest/maps-route #23588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andykao1213 merged 361 commits into from
Oct 26, 2022
Merged

[Maps] Onboarding @azure-rest/maps-route #23588

Show file tree
Hide file tree
Changes from 250 commits
Commits
Show all changes
361 commits
Select commit Hold shift + click to select a range
b66237d
Update maps dependency in pnpm-lock.yaml
Jul 26, 2022
64de5e9
Fix sample metadata errors
Jul 26, 2022
8248dea
Fix linting errors
Jul 27, 2022
75cf90f
Fix linting errors
dubiety Jul 27, 2022
7863b9e
Fix run time error
Jul 27, 2022
ff5d8a5
Update package.json in samples folder
Jul 27, 2022
cce0f9e
Fix linting errors
dubiety Jul 27, 2022
45eae6e
Fix linting errors
dubiety Jul 27, 2022
33d39a7
Add changelog for maps-common
Jul 28, 2022
fe0ede3
Update recording files for maps-search
Jul 28, 2022
0f2d40c
Add test.yml for maps-search
Jul 28, 2022
e8776d5
Add tests.yml for render and route
Jul 28, 2022
098ccdc
Update tests.yml
Jul 28, 2022
3a4f796
Update test-resources.json for maps
dubiety Jul 28, 2022
c529bdd
Fix tests.yml format error
dubiety Jul 28, 2022
70596eb
Update env vars and remove unused export var
Jul 28, 2022
dc04541
Remove unused code
dubiety Jul 29, 2022
1365891
Fix lock file
andykao1213 Aug 24, 2022
9cea83b
Remove route & render
andykao1213 Aug 25, 2022
fd5ac05
Replace `beginGet*Batch` with `resume*Batch`
andykao1213 Aug 29, 2022
ea49a98
Update recording
andykao1213 Aug 29, 2022
688a2e0
Make the endpoint of `MapsSearchClient` configurable
andykao1213 Aug 31, 2022
c18836e
Change LatLon from an interface to a tuple
andykao1213 Sep 1, 2022
262e74c
Make the props `coordinates` and `countryCodeFilter` optional
andykao1213 Sep 1, 2022
64ab74f
fixup! Remove route & render
andykao1213 Sep 1, 2022
18f84ec
Adjust CHANGELOGs of maps-search & common
andykao1213 Sep 1, 2022
ea70218
Update samples
andykao1213 Sep 5, 2022
b888756
Add batchRequest sample
andykao1213 Sep 5, 2022
c03e5b4
Add a new sample searchAddressResult
andykao1213 Sep 5, 2022
f86afb8
Update search.ts and its examples
andykao1213 Sep 5, 2022
de2378c
enhance code example in README.md
andykao1213 Sep 5, 2022
4a922cc
comment unused import
andykao1213 Sep 5, 2022
e4780e7
Update recording for maps-search
andykao1213 Sep 5, 2022
bf4bd29
remove redundant recording files
andykao1213 Sep 5, 2022
9ca9ff2
Add maps-search
alankashiwa Dec 8, 2021
84e0f98
Rename LatLong to LatLon
alankashiwa Dec 8, 2021
b4fadd6
Fix constructor Readme doc
alankashiwa Dec 8, 2021
5bb423c
Update readme to new signature
alankashiwa Dec 9, 2021
e1397b0
Add tests partially
alankashiwa Dec 9, 2021
7aafe23
Change LatLon/BoundingBox to interfaces
alankashiwa Dec 10, 2021
55bec4e
Reduce the number of constructor overloading
alankashiwa Dec 10, 2021
d9b6413
Rename SearchClient as MapsSearchClient
alankashiwa Dec 13, 2021
82aa02d
Add options mapper tests
alankashiwa Dec 16, 2021
979d879
Add result type mapper tests (in progress)
alankashiwa Dec 17, 2021
360697d
rename clientId to mapsAccountClientId
alankashiwa Dec 21, 2021
67b123d
listPolygons -> getPolygons
alankashiwa Dec 22, 2021
2a6f55c
getPointOfInterestCategoryTree -> getPointOfInterestCategories
alankashiwa Dec 22, 2021
077981c
Expose missing model
alankashiwa Dec 23, 2021
de87099
Add alternative input file for quick experiment
alankashiwa Dec 25, 2021
01aa61f
Regenerate code and make changes accordingly
alankashiwa Dec 30, 2021
8016547
Reduce number of overloads of fuzzy searches
alankashiwa Dec 31, 2021
7d19057
Add geojson types
alankashiwa Jan 1, 2022
2cdc2b5
Adopting new geojson definitions
alankashiwa Jan 3, 2022
752328d
Change test specs to align with new method names
alankashiwa Jan 3, 2022
7f86f4c
clean up models and tsconfig
alankashiwa Jan 7, 2022
fedd708
Expose Known* models
alankashiwa Jan 7, 2022
5136fbd
Remove batch sync methods
alankashiwa Feb 11, 2022
12c08fa
Add public tests (non-batch)
alankashiwa Feb 11, 2022
9367451
move model
alankashiwa Feb 14, 2022
b660b01
Add docstrings
alankashiwa Feb 17, 2022
610eb89
Start polling in begin* method
alankashiwa Feb 17, 2022
975416f
Refactor BatchPoller for retrieving batchId
alankashiwa Feb 17, 2022
abd2489
Finalize batch pollers
alankashiwa Feb 18, 2022
e2698d3
Readd batch methods
alankashiwa Feb 18, 2022
3328be7
Update generated code
alankashiwa Feb 21, 2022
72a1af8
Finalize batch signature
alankashiwa Feb 22, 2022
878ae76
Rebuild samples & clean up
alankashiwa Feb 22, 2022
8b55ebd
Add AAD tests
alankashiwa Feb 22, 2022
f7484ce
Clean up Swagger readme
alankashiwa Feb 23, 2022
16a799a
Fix spelling
alankashiwa Feb 23, 2022
14c6ad2
Add initial files for @azure/maps-route module
alankashiwa Feb 23, 2022
f07934a
maps-search: change comments and perform formatting
alankashiwa Feb 25, 2022
808b008
Methods options and testing skeleton for maps-route
alankashiwa Feb 25, 2022
6d57aa5
maps-search: refactor options
alankashiwa Mar 10, 2022
7f60e28
Improve convenience layer for non-LRO methods
alankashiwa Mar 13, 2022
0884373
Change variable names
alankashiwa Mar 14, 2022
d04a87d
Complete batch methods
alankashiwa Mar 14, 2022
0a3f333
update maps-search Readme
alankashiwa Mar 14, 2022
88a6b84
Update maps-route Readme
alankashiwa Mar 14, 2022
6283712
Add generated samples for maps-route
alankashiwa Mar 14, 2022
d80e711
Update samples for maps-search
alankashiwa Mar 14, 2022
1e468c7
Delete backup file
alankashiwa Mar 14, 2022
9832fae
Add maps-common module
alankashiwa Mar 15, 2022
ebb11bc
Update maps-route/maps-search to use maps-common
alankashiwa Mar 15, 2022
9a0a757
maps-render: first draft
alankashiwa Mar 16, 2022
00b67e5
Use LatLon/BoundingBox from maps-common
alankashiwa Mar 17, 2022
6c21c75
Complete maps-render with tests
alankashiwa Mar 23, 2022
2ae0c92
Expose required types from maps-route
alankashiwa Mar 23, 2022
2a3c091
Expose required types from maps-search
alankashiwa Mar 23, 2022
84043e4
Complete unit tests for maps-render
alankashiwa Mar 30, 2022
59790d5
Update maps-render README
alankashiwa Apr 1, 2022
211bf59
Update samples
alankashiwa Apr 1, 2022
aa1f63c
Fix comment/strings
alankashiwa Apr 16, 2022
4886901
Fix comment/strings
alankashiwa Apr 16, 2022
d27c798
Update Route comment/interface
alankashiwa May 1, 2022
2e8be82
Regenerate code
alankashiwa Jun 15, 2022
5ee3714
Update files
alankashiwa Jun 15, 2022
8f5ea4f
Define required fields and fix code
alankashiwa Jun 22, 2022
9f25889
Remove non-poller batch methods
alankashiwa Jun 22, 2022
d12d28b
Fix playback test failure
alankashiwa Jun 22, 2022
a47663c
Rename parts of model names
alankashiwa Jun 23, 2022
d3f5a7c
Rename remaining parts of models according to review feedback
alankashiwa Jun 23, 2022
ba8dd58
Remove TODO comments
alankashiwa Jun 24, 2022
de4578d
Update Reamdme transform to reflect latest swagger
alankashiwa Jun 24, 2022
0ff85a9
Change key policy name
alankashiwa Jun 24, 2022
161eea7
Simplify batch item error model
alankashiwa Jun 24, 2022
24fc0a7
Add brower tests
alankashiwa Jun 27, 2022
04450d3
Turn maps-common into internal module
alankashiwa Jun 27, 2022
99fac9e
Rearrange Readme
alankashiwa Jun 28, 2022
ca5ebb3
Rewrite Readme for common
alankashiwa Jun 28, 2022
acd2d18
Remove batch-sync methods
alankashiwa Jun 28, 2022
dc8130e
Route required fields: part 1
alankashiwa Jun 28, 2022
0484dd5
Route required fields: part 2
alankashiwa Jun 29, 2022
227e278
Add AAD back
alankashiwa Jun 29, 2022
e1039a9
Route model fixes #1
alankashiwa Jun 30, 2022
deb143a
Route model fixes #2 + geojson named tuples
alankashiwa Jun 30, 2022
51c0361
Refine geojson types
alankashiwa Jun 30, 2022
6747930
Aliased a few method options
alankashiwa Jun 30, 2022
5cd478d
maps-render required fields part 1
alankashiwa Jul 1, 2022
ad80121
Do not validate budget parameters
alankashiwa Jul 1, 2022
3209919
Revert "Do not validate budget parameters"
alankashiwa Jul 4, 2022
4c2cc89
Rename MapTileset to TileJson
alankashiwa Jul 4, 2022
ced730e
Render: model rename & type improvement
alankashiwa Jul 4, 2022
b06d6c2
Explicitly transform image range
alankashiwa Jul 5, 2022
1c1a5ed
Fix route record tests
alankashiwa Jul 13, 2022
3e58aa8
Update map account creation commands in Readme
alankashiwa Jul 13, 2022
8fa8c35
Update Readme/docstrings/samples for Search/Route/Render
alankashiwa Jul 13, 2022
15f3ea0
Remove rollup and use dev-tool instead
dubiety Jul 13, 2022
a60e154
Remove some empty tests
Jul 13, 2022
c284c7c
Add AAD test case and make file name shorter
Jul 13, 2022
df31dbb
Update test cases
Jul 14, 2022
856fbb3
Update cspell rules
dubiety Jul 21, 2022
49cea8e
Update recording files
dubiety Jul 18, 2022
b417a0e
Simplify test cases
dubiety Jul 18, 2022
030e416
Sync cspell.json from upstream
Jul 19, 2022
fe95b21
Use test-recorder 2.0 and update unit test cases
Jul 19, 2022
2bb38fb
Push wrong browsers recording files
Jul 19, 2022
d84d7fc
Update settings to support recording
dubiety Jul 20, 2022
959fad3
Fix dependency errors
dubiety Jul 21, 2022
1ed66fb
Upgrade api-recorder and fix errors
Jul 26, 2022
1c969b1
Code refinement
Jul 26, 2022
7a689f7
Update maps search recording files
Jul 26, 2022
d310f1f
Update karma.conf.js format
Jul 26, 2022
7b3de33
Update recording files and settings
Jul 26, 2022
ea8666d
Fix broken links
Jul 26, 2022
7693990
Update maps dependency in pnpm-lock.yaml
Jul 26, 2022
64397ef
Fix sample metadata errors
Jul 26, 2022
79f4503
Fix linting errors
Jul 27, 2022
1198269
Fix linting errors
dubiety Jul 27, 2022
48fd646
Fix run time error
Jul 27, 2022
3b839ed
Update package.json in samples folder
Jul 27, 2022
1432a51
Fix linting errors
dubiety Jul 27, 2022
56a6ccd
Fix linting errors
dubiety Jul 27, 2022
859d199
Add changelog for maps-common
Jul 28, 2022
27e0ee1
Update recording files for maps-search
Jul 28, 2022
478b1e2
Add test.yml for maps-search
Jul 28, 2022
b8c88d9
Add tests.yml for render and route
Jul 28, 2022
45079a5
Update tests.yml
Jul 28, 2022
218dd52
Update test-resources.json for maps
dubiety Jul 28, 2022
ecb26b4
Fix tests.yml format error
dubiety Jul 28, 2022
1efc226
Update env vars and remove unused export var
Jul 28, 2022
96d8590
Remove unused code
dubiety Jul 29, 2022
e29b20d
Fix lock file
andykao1213 Aug 24, 2022
51506f3
Remove maps-render
andykao1213 Sep 6, 2022
26d2878
Merge branch 'andrewkao/maps-search' into andrewkao/maps-route
andykao1213 Sep 6, 2022
d48d5ac
fixup! Change LatLon from an interface to a tuple
andykao1213 Sep 6, 2022
5b8b57e
Comment the future doc link
andykao1213 Sep 7, 2022
435c06a
Update doc & fix type issue
andykao1213 Sep 7, 2022
bce35b2
Merge remote-tracking branch 'upstream/main' into andrewkao/maps-search
andykao1213 Sep 8, 2022
7d06868
fix lint issues
andykao1213 Sep 13, 2022
7cc9e9e
Merge remote-tracking branch 'upstream/main' into andrewkao/maps-search
andykao1213 Sep 13, 2022
467ce32
Regenerate API View
andykao1213 Sep 13, 2022
0e926dd
Comment the whole [apiref] since the original syntax cannot pass the …
andykao1213 Sep 13, 2022
6927922
Fix issue related to the change of maps-common
andykao1213 Sep 13, 2022
2be3c3b
Update test recording
andykao1213 Sep 13, 2022
8f3b125
Remove maps-common from the Artifacts
andykao1213 Sep 14, 2022
58afa84
remove unused dependencies
andykao1213 Sep 15, 2022
19da7ce
Add impression in README so we can track the page views
andykao1213 Sep 15, 2022
f28c0f3
Remove `AZURE_LOG_LEVEL` in test.yml
andykao1213 Sep 15, 2022
f105d20
Update samples
andykao1213 Sep 16, 2022
da93ad9
Patch {} to properties for GeoJsonPolygon
andykao1213 Sep 16, 2022
d9618a7
rename maxDetourTime to maxDetourTimeInSeconds
andykao1213 Sep 16, 2022
70e7ddd
Update recordings
andykao1213 Sep 16, 2022
1b1508c
Remove any
andykao1213 Sep 19, 2022
b5390e3
Rename to detourTimeInSeconds to align the convention
andykao1213 Sep 19, 2022
1fd4459
Change the test.yml EnvVar
andykao1213 Sep 19, 2022
a620930
Merge remote-tracking branch 'upstream/main' into andrewkao/maps-search
andykao1213 Sep 19, 2022
5d7cf7d
Merge remote-tracking branch 'upstream/main' into andrewkao/maps-search
andykao1213 Sep 20, 2022
d28da36
Rename numResults to numberResults
andykao1213 Sep 21, 2022
979cae7
Add document comment
andykao1213 Sep 21, 2022
502d7dc
Merge remote-tracking branch 'upstream/main' into andrewkao/maps-search
andykao1213 Sep 21, 2022
379d411
Merge branch 'andrewkao/maps-search' into andrewkao/maps-route
andykao1213 Sep 22, 2022
0086c90
Add endpoint options to MapsRouteClient
andykao1213 Sep 22, 2022
0ba4cbc
Remove unused dependencies in maps-route
andykao1213 Sep 22, 2022
3faaefb
fixup! Change the test.yml EnvVar
andykao1213 Sep 26, 2022
862e3d8
Update interfaces & documents
andykao1213 Sep 26, 2022
03119aa
Update changelog
andykao1213 Sep 26, 2022
d594729
Merge getRouteDirection with the additional parameter one
andykao1213 Sep 26, 2022
34a4bff
Update samples
andykao1213 Sep 26, 2022
9100bda
Make the `maps-common to a published package
andykao1213 Sep 27, 2022
76d9057
Update the import of `maps-common` in `maps-search`
andykao1213 Sep 27, 2022
a7e33ec
Merge remote-tracking branch 'upstream/main' into andrewkao/maps-search
andykao1213 Sep 27, 2022
02a0517
Fix CI Issue
andykao1213 Sep 27, 2022
fd7722f
Add documents for geojson
andykao1213 Sep 28, 2022
5492bb7
Update the samples & readme
andykao1213 Sep 28, 2022
2b8a317
Merge branch 'andrewkao/maps-search' into andrewkao/maps-route
andykao1213 Sep 28, 2022
fad6693
Leverage maps-common package in mpas-route
andykao1213 Sep 28, 2022
384217c
chore update
andykao1213 Sep 28, 2022
710745d
Remove unnecessary eslint config
andykao1213 Sep 28, 2022
01f4e60
Merge remote-tracking branch 'upstream/main' into andrewkao/maps-search
andykao1213 Sep 28, 2022
e4258c3
Merge branch 'andrewkao/maps-search' into andrewkao/maps-route
andykao1213 Sep 28, 2022
62e9431
Merge remote-tracking branch 'upstream/main' into andrewkao/maps-route
andykao1213 Oct 11, 2022
bb920cc
WIP: Remove LRO generation
andykao1213 Oct 11, 2022
06cc76d
WIP: refactor mapsRouteClient
andykao1213 Oct 11, 2022
dd53c4d
WIP: first generation
andykao1213 Oct 17, 2022
3e85fe2
Format the generated code
andykao1213 Oct 17, 2022
93daaf5
Support AAD
andykao1213 Oct 18, 2022
212fc30
Transform the model name
andykao1213 Oct 18, 2022
1650b8d
Add helper functions
andykao1213 Oct 19, 2022
d17ee38
Add a sample - route.ts
andykao1213 Oct 19, 2022
8269886
Add samples for lro
andykao1213 Oct 19, 2022
ccd165b
Add test
andykao1213 Oct 20, 2022
30bffae
Generate samples
andykao1213 Oct 20, 2022
6e4cdf3
Add api view
andykao1213 Oct 20, 2022
1be8286
Update the generation
andykao1213 Oct 20, 2022
e2805dc
WIP: ReadMe
andykao1213 Oct 20, 2022
04b3765
Rename "computeBestOrder" to "computeBestWaypointOrder"
andykao1213 Oct 21, 2022
4a806dd
Refine README
andykao1213 Oct 21, 2022
70fc2aa
Rename model
andykao1213 Oct 21, 2022
f3030f2
Add test createRouteDirectionsBatchRequest
andykao1213 Oct 21, 2022
1bb753e
Fix lint issue
andykao1213 Oct 21, 2022
dd1593b
Add missing metadata
andykao1213 Oct 21, 2022
066b9bd
Remove maps-route/
andykao1213 Oct 21, 2022
96781dc
Update CI issue
andykao1213 Oct 21, 2022
f263b5e
Fix merged issue
andykao1213 Oct 21, 2022
ff4a0e1
Merge remote-tracking branch 'upstream/main' into maps/onboarding-map…
andykao1213 Oct 21, 2022
ff70bf4
Update version rule for maps-common
andykao1213 Oct 21, 2022
a31c816
Update CI name
andykao1213 Oct 21, 2022
912873d
Remove extra lint config
andykao1213 Oct 24, 2022
cd41516
Use `require` in the README for consistency
andykao1213 Oct 24, 2022
f389835
Regenerate the samples
andykao1213 Oct 24, 2022
1735ec6
Remove redundant recording files
andykao1213 Oct 24, 2022
d0d050d
Remove unused parameters in test-resources.json
andykao1213 Oct 24, 2022
39d891f
Refine readme snippet
andykao1213 Oct 24, 2022
20a52a2
Log something specific for the result
andykao1213 Oct 25, 2022
5e403e0
Update samples
andykao1213 Oct 25, 2022
8154f23
Split the route.ts into 3
andykao1213 Oct 25, 2022
0e52644
Remove model rename
andykao1213 Oct 26, 2022
eecbf53
Use default export for RLC factory function
andykao1213 Oct 26, 2022
3e039bc
Merge remote-tracking branch 'upstream/main' into maps/onboarding-map…
andykao1213 Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .vscode/cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,10 @@
"filename": "sdk/maps/maps-search/review/maps-search.api.md",
"words": ["bbox", "Neighbourhood", "Xstr"]
},
{
"filename": "sdk/maps/maps-route-rest/review/maps-route.api.md",
Copy link
Member

@joheredi joheredi Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ckairen I wonder if there is a way to ignore all folders suffixed with -rest from cspell. Rest clients don't do any renames on the service properties and names and are autogenerated.

"words": ["bbox", "UTURN"]
},
{
"filename": "sdk/apimanagement/api-management-custom-widgets-scaffolder/review/api-management-custom-widgets-scaffolder.api.md",
"words": ["scaffolder", "APIM"]
Expand Down
Loading