Skip to content

[core-rest-pipeline] Fix issue with afterPhase policies getting run later than expected#22924

Merged
xirzec merged 1 commit intoAzure:mainfrom
xirzec:fixSignPhaseIssue
Aug 17, 2022
Merged

[core-rest-pipeline] Fix issue with afterPhase policies getting run later than expected#22924
xirzec merged 1 commit intoAzure:mainfrom
xirzec:fixSignPhaseIssue

Conversation

@xirzec
Copy link
Member

@xirzec xirzec commented Aug 17, 2022

Packages impacted by this PR

@azure/core-rest-pipeline

Describe the problem that is addressed by this PR

Policies using 'afterPhase' would get executed later than expected due to noPhase not getting run again until the full phase walk finished.

Are there test cases added in this PR?

Yes

@xirzec xirzec requested review from dgetu and joheredi August 17, 2022 19:36
@ghost ghost added the Azure.Core label Aug 17, 2022
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@xirzec xirzec merged commit 0a02263 into Azure:main Aug 17, 2022
@xirzec xirzec deleted the fixSignPhaseIssue branch August 17, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants