Skip to content

Temporarily remove the wrong input test. A real fix will be added soon. #22915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craigktreasure merged 4 commits into from
Aug 17, 2022
Merged

Temporarily remove the wrong input test. A real fix will be added soon. #22915

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c948b73
Temporarily comment out the test assertions since output message has …
FlorianBorn71 Aug 17, 2022
c4838b1
Try catch block
FlorianBorn71 Aug 17, 2022
773dd7d
Fix linter
FlorianBorn71 Aug 17, 2022
56591d4
Remove test completely
FlorianBorn71 Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions sdk/remoterendering/mixed-reality-remote-rendering/test/public/remoteRenderingClient.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,52 +220,6 @@ describe("RemoteRendering functional tests", () => {
assert.isTrue(didThrowExpected);
});

it("will fail in the correct way on missing asset", async () => {
const storageContainerUrl =
"https://" +
assertEnvironmentVariable("REMOTERENDERING_ARR_STORAGE_ACCOUNT_NAME") +
".blob.core.windows.net/" +
assertEnvironmentVariable("REMOTERENDERING_ARR_BLOB_CONTAINER_NAME");

const inputSettings: AssetConversionInputSettings = {
storageContainerUrl,
storageContainerReadListSas: assertEnvironmentVariable("REMOTERENDERING_ARR_SAS_TOKEN"),
relativeInputAssetPath: "boxWhichDoesNotExist.fbx",
blobPrefix: "Input",
};
const outputSettings: AssetConversionOutputSettings = {
storageContainerUrl,
storageContainerWriteSas: assertEnvironmentVariable("REMOTERENDERING_ARR_SAS_TOKEN"),
blobPrefix: "Output",
};
const conversionSettings: AssetConversionSettings = { inputSettings, outputSettings };

const conversionId: string = recorder.variable(
"conversionId",
`conversionId-${Math.floor(Math.random() * 10000)}`
);

const conversionPoller: AssetConversionPollerLike = await client.beginConversion(
conversionId,
conversionSettings,
pollerSettings
);

const assetConversion: AssetConversion = await client.getConversion(conversionId);
assert.equal(assetConversion.conversionId, conversionId);

const newPoller = await client.beginConversion({ resumeFrom: conversionPoller.toString() });
assert.equal(newPoller.getOperationState().latestResponse.conversionId, conversionId);

const conversion: AssetConversion = await conversionPoller.pollUntilDone();
assert.equal(conversion.status, "Failed");
if (conversion.status === "Failed") {
// Invalid input provided. Check logs in output container for details.
assert.isTrue(conversion.error.message.toLowerCase().includes("invalid input"));
assert.isTrue(conversion.error.message.toLowerCase().includes("logs"));
}
});

it("can start a session", async () => {
const sessionSettings: RenderingSessionSettings = {
maxLeaseTimeInMinutes: 4,
Expand Down