[notification hubs] Beta 2 Release#22901
Merged
mpodwysocki merged 10 commits intoAzure:mainfrom Aug 17, 2022
Merged
Conversation
mpodwysocki
requested review from
deyaaeldeen,
jeremymeng,
praveenkuttappan,
witemple-msft and
xirzec
as code owners
Collaborator
|
API change check API changes are not detected in this pull request. |
xirzec
reviewed
Aug 16, 2022
Member
xirzec
left a comment
xirzec
left a comment
There was a problem hiding this comment.
Minor comments but looks good! Please file the issue to track updating the hmac code in core-util if you haven't already.
sdk/notificationhubs/notification-hubs/src/utils/connectionStringUtils.ts
Outdated
Show resolved
Hide resolved
joheredi
reviewed
Aug 17, 2022
| import { createOrUpdateRegistrationDescription } from "./internal/_createOrUpdateRegistrationDescription.js"; | ||
| import { tracingClient } from "../utils/tracing.js"; | ||
|
|
||
| const OPERATION_NAME = "createOrUpdateRegistration"; |
Member
There was a problem hiding this comment.
Should this be createRegistration?
joheredi
reviewed
Aug 17, 2022
| ## 1.0.0-beta.2 (2022-08-17) | ||
|
|
||
| - Removed internal dependencies of `@azure/core-amqp` and inlined code | ||
| - Added Telemetry using the `X-MS-AZSDK-Telemetry` header. |
Member
There was a problem hiding this comment.
nit: can we have all parts of this header name with the same casing?
joheredi
reviewed
Aug 17, 2022
joheredi
approved these changes
Aug 17, 2022
Member
joheredi
left a comment
joheredi
left a comment
There was a problem hiding this comment.
Looks good, left a couple of minor comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
X-MS-AZSDK-TelemetryheaderUser-Agentheader for notification hubs/dist/index.jsto be CJS via/dist/index.cjs@azure/core-amqpWhat are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists