[KeyVault] Fix listPropertiesOfSecretVersions pagination in keyvault-secrets#22898
Merged
timovv merged 6 commits intoAzure:mainfrom Aug 15, 2022
Merged
Conversation
Collaborator
|
API change check API changes are not detected in this pull request. |
xirzec
approved these changes
Aug 15, 2022
Member
xirzec
left a comment
There was a problem hiding this comment.
Thanks for debugging this one so quickly!
This was referenced Aug 22, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/keyvault-secretsIssues associated with this PR
Describe the problem that is addressed by this PR
Pagination for
listPropertiesOfSecretVersionswas not calling the appropriate method to get the next page. It looks like during the migration to Core v2, this change was missed. It was not picked up by the tests, since the tests did not enforce a maximum page size, which meant that the service only returned one page of results and the actual pagination logic was not covered.This PR:
getSecretVersions(correct in Core v1, incorrect in Core v2) togetSecretVersionsNext(correct in Core v2)