Fix a hang issue in downloading when there's transient network issue#22894
Merged
Fix a hang issue in downloading when there's transient network issue#22894
Conversation
EmmaZhu
requested review from
XiaoningLiu,
jeremymeng,
jiacfan,
ljian3377 and
vinjiang
as code owners
ghost
added
the
Collaborator
|
API change check API changes are not detected in this pull request. |
ljian3377
approved these changes
Aug 16, 2022
ljian3377
reviewed
Aug 16, 2022
| export const DEFAULT_BLOB_DOWNLOAD_BLOCK_BYTES: number = 4 * 1024 * 1024; // 4MB | ||
| export const DEFAULT_MAX_DOWNLOAD_RETRY_REQUESTS: number = 5; | ||
|
|
||
| export const REQUEST_TIMEOUT: number = 100 * 1000; // In ms |
Member
There was a problem hiding this comment.
Are we able to make this configurable?
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/storage-blob
@azure/storage-file-share
Issues associated with this PR
Describe the problem that is addressed by this PR
Fix a hang issue in downloading when there's transient network issue
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists