[@azure/search-documents] Enable national cloud support for Azure Search SDK#22887
Merged
sarangan12 merged 4 commits intoAzure:mainfrom Aug 15, 2022
Merged
[@azure/search-documents] Enable national cloud support for Azure Search SDK#22887sarangan12 merged 4 commits intoAzure:mainfrom
sarangan12 merged 4 commits intoAzure:mainfrom
Conversation
sarangan12
requested review from
bterlson,
jeremymeng and
xirzec
as code owners
ghost
added
the
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
xirzec
reviewed
Aug 12, 2022
Member
xirzec
left a comment
xirzec
left a comment
There was a problem hiding this comment.
A nice little feature, just one concern about the audience typing on the options bag
| export interface SearchClientOptions extends ExtendedCommonClientOptions { | ||
| // @deprecated | ||
| apiVersion?: string; | ||
| audience?: SearchAudience; |
Member
There was a problem hiding this comment.
I'm concerned about taking the enum type here, since presumably there will be additional national clouds or perhaps even unlisted ones that can be passed as well. I feel like this should be string but have a ref comment that mentions using the SearchAudience enum for convenience.
Contributor
Author
There was a problem hiding this comment.
@xirzec You are right. Modified to make it string and changed the other name to include Known
3 tasks
sarangan12
added a commit
that referenced
this pull request
Jun 3, 2024
…Ks (#29871) ### Packages impacted by this PR 1. @azure/monitor-ingestion 2. @azure/monitor-query ### Issues associated with this PR 1. [#27280](#27280) 2. [#28821](#28821) ### Describe the problem that is addressed by this PR In order to support sovereign clouds, we must be able to allow the SDK users to specify the endpoints and audience parameters. The users could already specify/modify the endpoint parameter. This PR will enable the users to do the same for audience. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? No special design concerns to discuss. ### Provide a list of related PRs _(if any)_ #22887 ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [X] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [X] Added a changelog (if necessary) @KarishmaGhiya @srnagar Please review and approve the PR. @xirzec FYI --------- Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/search-documentsIssues associated with this PR
#22813
Describe the problem that is addressed by this PR
This PR is to enable national cloud support for Azure Search Documents. This PR uses the .NET PR - Azure/azure-sdk-for-net#30316 as reference.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
This is a standard straight forward implementation. No specific design concerns.
Provide a list of related PRs (if any)
Azure/azure-sdk-for-net#30316
Checklists