[communication] update to core-tracing 1.0#22855
Merged
mpodwysocki merged 27 commits intomainfrom Aug 12, 2022
Merged
Conversation
ghost
added
the
mpodwysocki
requested review from
AikoBB,
maximrytych-ms and
petrsvihlik
as code owners
mpodwysocki
requested review from
RoyHerrod,
danielav7,
lucasrsant,
miguhern and
whisper6284
as code owners
mpodwysocki
requested review from
bterlson,
jeremymeng and
xirzec
as code owners
Collaborator
|
API change check API changes are not detected in this pull request. |
petrsvihlik
suggested changes
Aug 10, 2022
Contributor
petrsvihlik
left a comment
petrsvihlik
left a comment
There was a problem hiding this comment.
reviewed common+identity and left a couple of minor comments regarding versioning. otherwise, the code looks fine....actually, it looks fantastic :) I love the new super-clean way of writing the client methods! 😍
Co-authored-by: Petr Švihlík <petrsvihlik@microsoft.com>
Co-authored-by: Petr Švihlík <petrsvihlik@microsoft.com>
Co-authored-by: Petr Švihlík <petrsvihlik@microsoft.com>
petrsvihlik
reviewed
Aug 11, 2022
sdk/communication/communication-identity/src/generated/src/identityRestClient.ts
Outdated
Show resolved
Hide resolved
petrsvihlik
approved these changes
Aug 11, 2022
Contributor
petrsvihlik
left a comment
petrsvihlik
left a comment
There was a problem hiding this comment.
I made a couple more adjustments. Communication Identity and Common are fine now. Let's wait for the other modalities to confirm.
Contributor
Author
|
/check-enforcer reset |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
Updating to core tracing 1.0 from the beta release.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists