[core-http-compat] Policy factory compat#22798
Merged
xirzec merged 3 commits intoAzure:mainfrom Aug 16, 2022
Merged
Conversation
xirzec
added
Client
xirzec
requested review from
bterlson,
deyaaeldeen and
jeremymeng
as code owners
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
joheredi
approved these changes
Aug 15, 2022
Member
joheredi
left a comment
joheredi
left a comment
There was a problem hiding this comment.
LGTM! I like the Proxy approach :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New compat behavior requested by storage team:
This will allow Storage to keep using their
PipelineLikeinterface without breaking changes by allowing old-style http policies to participate in corev2 pipelines.