Skip to content

Fix failures in passing or converting permissions#22712

Merged
EmmaZhu merged 1 commit intomainfrom
storage/sticky-bit
Aug 16, 2022
Merged

Fix failures in passing or converting permissions#22712
EmmaZhu merged 1 commit intomainfrom
storage/sticky-bit

Conversation

@EmmaZhu
Copy link
Copy Markdown
Member

@EmmaZhu EmmaZhu commented Jul 26, 2022

Packages impacted by this PR

@azure/storage-file-datalake

Issues associated with this PR

Describe the problem that is addressed by this PR

For pathClient.setPermission interface, following is doc for permission string format:

    Optional and only valid if Hierarchical Namespace is enabled for the account. Sets POSIX access permissions for the file owner, the file owning group, and others. Each class may be granted read(4), write(2), or execute(1) permission. Both symbolic (rwxrw-rw-) and 4-digit octal notation (e.g. 0766) are supported. 
    The sticky bit is also supported and in symbolic notation, its represented either by the letter t or T in the final character-place depending on whether the execution bit for the others category is set or unset respectively (e.g. rwxrw-rw- with sticky bit is represented as rwxrw-rwT. A rwxrw-rwx with sticky bit is represented as rwxrw-rwt), absence of t or T indicates sticky bit not set. In 4-digit octal notation, its represented by 1st digit (e.g. 1766 represents rwxrw-rw- with sticky bit and 0766 represents rwxrw-rw- without sticky bit). 
  Invalid in conjunction with x-ms-acl.

The SDK currently only support 't', but doesn't support 'T'. This PR is to add support for 'T'.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator? No
  • Added a changelog (if necessary)

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Jul 26, 2022
@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@EmmaZhu EmmaZhu force-pushed the storage/sticky-bit branch from ad50db3 to 5d67257 Compare July 27, 2022 03:17
@EmmaZhu EmmaZhu force-pushed the storage/sticky-bit branch from 5d67257 to c3d2753 Compare August 16, 2022 06:53
@EmmaZhu EmmaZhu enabled auto-merge (squash) August 16, 2022 07:15
@EmmaZhu EmmaZhu merged commit 68c9acb into main Aug 16, 2022
@EmmaZhu EmmaZhu deleted the storage/sticky-bit branch August 16, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants