Merged
Conversation
kpajdzik
approved these changes
Apr 10, 2019
Member
|
For consistency with the specs repo lets move this to the applicationinsights folder instead of appinsights. |
KarishmaGhiya
force-pushed
the
moveArmAppInsights
branch
from
346e92a to
4033817
Compare
Member
|
You have a typo in your folder rename you left out an |
…hts, fixed folder spelling
KarishmaGhiya
force-pushed
the
moveArmAppInsights
branch
from
9b79aaf to
9b4d7d8
Compare
weshaggard
approved these changes
Apr 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving packages for arm-appinsights from packages@Azure and putting them under an
sdkdirectory.A few changes that have been made:
The source code directory
libhas been renamed tosrcAll the links in various files referencing
libhave been updated tosrcThe paths of all the data-plane package under appinsights service (@azure/arm-appinsights) have been updated eg:
packages/@azure/arm-appinsightsto the new structure pathsdk/appservice/arm-appinsightsto follow the structure sdk/servicename/packagenameAll the corresponding links in different files like package.json, etc have also been updated for the new structure path
I have also updated the path in README.md (typescript) for azure-rest-api-specs.
Please review Azure/azure-rest-api-specs#5602
@salameer @daschult @kpajdzik @Azure/azure-sdk-eng