[Schema Registry Avro] Post release#20796
Merged
deyaaeldeen merged 1 commit intoAzure:mainfrom Mar 11, 2022
Merged
Conversation
ghost
added
the
|
|
||
| // serialize an object that matches the schema and put it in a message | ||
| const value = { firstName: "Jane", lastName: "Doe" }; | ||
| const message = await serializer.serializeMessageData(value, schema); |
Member
There was a problem hiding this comment.
I must have missed this in the PR to switch to using Serializer, but we actually renamed this to just serialize in .NET. We also renamed MessageWithMetadata to BinaryContent. Is there a reason not to do this same change in JS?
Member
Author
There was a problem hiding this comment.
Ok I will talk to @bterlson about those renames.
JoshLove-msft
approved these changes
Mar 11, 2022
jeremymeng
approved these changes
Mar 11, 2022
Member
jeremymeng
left a comment
jeremymeng
left a comment
There was a problem hiding this comment.
Looks good to me regarding the version change and sample publication.
WeiJun428
pushed a commit
to WeiJun428/azure-sdk-for-js
that referenced
this pull request
Mar 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard post-release changes and preparing for stable release in April.