Merged
Conversation
ghost
added
Azure.Core
Event Hubs
Azure.Identity
KeyVault
Service Bus
Storage
maorleger
requested review from
EmmaZhu,
HarshaNalluru,
XiaoningLiu,
bterlson,
deyaaeldeen,
jeremymeng,
jiacfan,
ljian3377,
mikeharder,
praveenkuttappan,
sadasant,
schaabs,
vicancy,
vinjiang,
witemple-msft and
xirzec
as code owners
HarshaNalluru
approved these changes
Mar 11, 2022
maorleger
force-pushed
the
upgrade-puppeteer
branch
from
6733faf to
c89f12b
Compare
jeremymeng
approved these changes
Mar 11, 2022
Member
jeremymeng
left a comment
jeremymeng
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the upgrade
WeiJun428
pushed a commit
to WeiJun428/azure-sdk-for-js
that referenced
this pull request
Mar 20, 2022
### Issues associated with this PR Resolves Azure#19234 ### Describe the problem that is addressed by this PR Upgrades puppeteer to the latest version ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? I looked through the changelog for puppeteer and did not see any major changes between 10 and 13 that should impact us
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues associated with this PR
Resolves #19234
Describe the problem that is addressed by this PR
Upgrades puppeteer to the latest version
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
I looked through the changelog for puppeteer and did not see any major changes between 10 and 13 that should impact us
Are there test cases added in this PR? (If not, why?)
No, this is a test dependency upgrade so if current tests pass we are good
Provide a list of related PRs (if any)
Command used to generate this PR: (Applicable only to SDK release request PRs)
rush add -p puppeeteer --dev --caret --make-consistentChecklists