[App Config] Migrate to core-v2 by HarshaNalluru · Pull Request #20766 · Azure/azure-sdk-for-js

HarshaNalluru · 2022-03-10T08:24:33Z

Packages impacted by this PR

@azure/app-configuration

Issues associated with this PR

Fixes #6484 with #20817
Fixes #15809

Describe the problem that is addressed by this PR

Migrating app-config to core-v2

Command used to generate this PR:***(Applicable only to SDK release request PRs)*

Generated code with generate:client script to get new core-v2 support.

Checklists

Added impacted package name to the issue description
Added a changelog (if necessary)

azure-sdk · 2022-03-10T08:36:45Z

API changes have been detected in @azure/app-configuration. You can review API changes here

check-enforcer · 2022-03-10T18:17:30Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

… harshan/app-config/15809

…er-ms" headers

… harshan/issue/20813

…u/azure-sdk-for-js into harshan/app-config/15809

…yStrategy.ts

…u/azure-sdk-for-js into harshan/issue/20813

… harshan/app-config/15809

sarangan12

@HarshaNalluru Can you tell where you are getting the CompatResponse from?

sarangan12

After offline discussion with Harsha, LGTM

jeremymeng

Looks good. just one nit comment

jeremymeng · 2022-04-07T17:57:11Z

-    );
-    return webResource;
-  }
+export function createAppConfigKeyCredentialPolicy(


nit: just appConfigKeyCredentialPolicy()

xirzec

Changes look good! Thanks for the updates, left some final thoughts. 👍

xirzec · 2022-04-07T18:20:54Z

+  result: T
+): asserts result is T & HttpResponseField<any> {
+  if (!hasUnderscoreResponse(result)) {
+    throw new Error(


I wonder if we should instead log this (and maybe have it fail our tests as well) -- basically I would be a little concerned about breaking someone's usage of app-config if they don't rely on _response. Maybe if it doesn't exist we can attach a message on _response that says to file a bug? :)

We can take this as a follow-up issue, though

oh that's a great point.

Works for me!

xirzec · 2022-04-07T18:25:14Z

+
+  if (hasUnderscoreResponse(kvp)) {
+    Object.defineProperty(response, "_response", {
+      enumerable: false,


not technically required (all flags default to false), but I'm fine with making it explicit

xirzec · 2022-04-07T18:30:22Z

  }
 }
+
+export function toWebResourceLike(request: PipelineRequest): WebResourceLike {


do we need full copies of all this compat code as test helpers? what are we validating?

I was lazy. Removed everything and simplified.
Tests are happy, I'm happy.

… harshan/app-config/15809

Co-authored-by: Jeff Fisher <xirzec@xirzec.com>

…olicy.ts Co-authored-by: Jeff Fisher <xirzec@xirzec.com>

…alluru/azure-sdk-for-js into harshan/app-config/15809

HarshaNalluru added 3 commits March 10, 2022 07:55

app-config changes - checkpoint- only 3 test failures

605ca61

core-rest-pipeline changes

217ac5c

test changes

9ace778

ghost added Azure.Core App Configuration Azure.ApplicationModel.Configuration labels Mar 10, 2022

HarshaNalluru added 3 commits March 10, 2022 09:35

credential fix

2fb659f

skip { timeout: 1 } tests in playback for now

c6832d1

lint:fix

14dec7c

This was referenced Mar 10, 2022

[core-rest-pipeline] Retry logic doesn't honor abort signal #20778

Closed

[core-rest-pipeline] Bug Fix - Retry logic to honor abort signal #20781

Merged

HarshaNalluru added 4 commits March 11, 2022 22:31

Merge branch 'main' of https://github.com/Azure/azure-sdk-for-js into…

d488e7b

… harshan/app-config/15809

expand throttlingRetryStrategy with "retry-after-ms", "x-ms-retry-aft…

3336fb1

…er-ms" headers

Merge branch 'main' of https://github.com/Azure/azure-sdk-for-js into…

44a78ee

… harshan/issue/20813

Expand test suite with "retry-after-ms" and "x-ms-retry-after-ms"

61ea4b7

HarshaNalluru mentioned this pull request Mar 12, 2022

[core-rest-pipeline] Support "retry-after-ms" and "x-ms-retry-after-ms" headers with the throttling policy #20817

Merged

2 tasks

HarshaNalluru added 4 commits March 12, 2022 00:31

changelog

65017fa

Merge branch 'harshan/issue/20813' of https://github.com/HarshaNallur…

a03d60d

…u/azure-sdk-for-js into harshan/app-config/15809

lock file

082e652

rely on core's throttling policy

4cc3e4f

HarshaNalluru changed the title ~~Harshan/app config/15809~~ [App Config] Migrate to core-v2 Mar 12, 2022

HarshaNalluru added 3 commits March 12, 2022 01:06

changelog

4f895fe

"version": "1.3.2" -> "version": "1.4.0",

1b1fc6c

Update sdk/core/core-rest-pipeline/src/retryStrategies/throttlingRetr…

3210497

…yStrategy.ts

HarshaNalluru mentioned this pull request Mar 14, 2022

[core-rest-pipeline] Throttling retry policy should account for abortSignal #16118

Closed

HarshaNalluru added 4 commits March 14, 2022 18:23

no new variable

31ef64e

Merge branch 'harshan/issue/20813' of https://github.com/harshanallur…

9bfdd96

…u/azure-sdk-for-js into harshan/issue/20813

no internal tag

eb63952

refactor

2752a5b

HarshaNalluru added 6 commits April 7, 2022 00:38

export utils

e6849fc

api report

6329aa2

api report

43f426c

format

a91ea11

Merge branch 'main' of https://github.com/Azure/azure-sdk-for-js into…

8eec27a

… harshan/app-config/15809

lock filke

ac7744f

sarangan12 approved these changes Apr 7, 2022

View reviewed changes

sarangan12 suggested changes Apr 7, 2022

View reviewed changes

sarangan12 approved these changes Apr 7, 2022

View reviewed changes

HarshaNalluru added 2 commits April 7, 2022 18:17

changelog

22a7855

TransferProgressEvent

ea17a2b

jeremymeng approved these changes Apr 7, 2022

View reviewed changes

HarshaNalluru added 2 commits April 7, 2022 18:22

1.3.0

e40a696

feedback address

968de64

xirzec approved these changes Apr 7, 2022

View reviewed changes

HarshaNalluru and others added 7 commits April 7, 2022 18:34

Merge branch 'main' of https://github.com/Azure/azure-sdk-for-js into…

43ec708

… harshan/app-config/15809

Update sdk/appconfiguration/app-configuration/src/internal/helpers.ts

95babed

Co-authored-by: Jeff Fisher <xirzec@xirzec.com>

Update sdk/appconfiguration/app-configuration/src/internal/synctokenp…

ae89abb

…olicy.ts Co-authored-by: Jeff Fisher <xirzec@xirzec.com>

unneeded excess code

0020980

Merge branch 'harshan/app-config/15809' of https://github.com/harshan…

34f419d

…alluru/azure-sdk-for-js into harshan/app-config/15809

don't throw

9b3889a

remove toUpperCase

23457e7

HarshaNalluru enabled auto-merge (squash) April 7, 2022 19:07

format

0ec8eb4

HarshaNalluru merged commit 2a07ed3 into Azure:main Apr 7, 2022

HarshaNalluru mentioned this pull request Apr 8, 2022

lock file regression revert #21321

Closed

HarshaNalluru deleted the harshan/app-config/15809 branch April 8, 2022 21:44

HarshaNalluru restored the harshan/app-config/15809 branch April 8, 2022 21:44

HarshaNalluru mentioned this pull request Apr 26, 2022

[app-config] AppConfigurationClient doesn't support PipelineOptions #10946

Closed

HarshaNalluru mentioned this pull request Apr 23, 2023

[Azure App Configuration sdk] Running into 401 issue when there is a trailing '/' in store endpoint #25463

Closed

6 tasks

Conversation

HarshaNalluru commented Mar 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Packages impacted by this PR

Issues associated with this PR

Describe the problem that is addressed by this PR

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

Uh oh!

azure-sdk commented Mar 10, 2022

Uh oh!

check-enforcer bot commented Mar 10, 2022

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

Uh oh!

sarangan12 left a comment

Choose a reason for hiding this comment

Uh oh!

sarangan12 left a comment

Choose a reason for hiding this comment

Uh oh!

jeremymeng left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xirzec left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

HarshaNalluru commented Mar 10, 2022 •

edited

Loading

Command used to generate this PR:***(Applicable only to SDK release request PRs)*