[Communication] - phone-numbers - Azure Core V2 migration cleanup #20696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the `package-name` property so the default user-agent is properly generated.
Require version 2.2.4 of @azure/core-lro, which implements a fix to the LRO implementation. This renders the workaround implemented in the phone-numbers package as unnecessary.
danielortega-msft
requested review from
RoyHerrod,
danielav7,
lucasrsant,
miguhern and
whisper6284
as code owners
automagicaly
approved these changes
Mar 7, 2022
lucasrsant
approved these changes
Mar 9, 2022
lucasrsant
left a comment
lucasrsant
left a comment
There was a problem hiding this comment.
Thanks for the very detailed PR description. It's been very helpful during code review!
3 tasks
WeiJun428
pushed a commit
to WeiJun428/azure-sdk-for-js
that referenced
this pull request
Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/communication-phone-numbersIssues associated with this PR
Describe the problem that is addressed by this PR
Address pending feedback from #20633. More specifically:
@azure/core-lrodependency to version 2.2.4 in order to remove LRO workaroundpackage-namein autorest configuration file, so the user agent of the client is properly generateduse-core-v2property in autorest configuration fileProvide a list of related PRs (if any)
Checklists