Add TTL to getRelayConfiguration.#20692
Conversation
|
API changes have been detected in API changes - getRelayConfiguration(user: CommunicationUserIdentifier, routeType?: RouteType, options?: GetRelayConfigurationOptions): Promise<CommunicationRelayConfiguration>;
+ getRelayConfiguration(ttl: number, options?: GetRelayConfigurationOptions): Promise<CommunicationRelayConfiguration>;
+ getRelayConfiguration(routeType: RouteType, ttl?: number, options?: GetRelayConfigurationOptions): Promise<CommunicationRelayConfiguration>;
+ getRelayConfiguration(user: CommunicationUserIdentifier, routeType?: RouteType, ttl?: number, options?: GetRelayConfigurationOptions): Promise<CommunicationRelayConfiguration>;
+ getRelayConfiguration(user: CommunicationUserIdentifier, ttl?: number, options?: GetRelayConfigurationOptions): Promise<CommunicationRelayConfiguration>; |
DominikMe
left a comment
There was a problem hiding this comment.
Cool feature, let's work on the API shape with optional args.
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
|
API changes have been detected in API changes - getRelayConfiguration(routeType: RouteType, options?: GetRelayConfigurationOptions): Promise<CommunicationRelayConfiguration>;
- getRelayConfiguration(user: CommunicationUserIdentifier, routeType?: RouteType, options?: GetRelayConfigurationOptions): Promise<CommunicationRelayConfiguration>;
- export interface GetRelayConfigurationOptions extends OperationOptions { }
+ export interface GetRelayConfigurationOptions extends OperationOptions {
+ id?: string;
+ routeType?: RouteType;
+ ttl?: number;
+ } |
DominikMe
left a comment
There was a problem hiding this comment.
Lgtm with comments!
+1 to Jose's comment about calling out the breaking change in the Changelog
joheredi
left a comment
There was a problem hiding this comment.
Looks good, left a couple of comments. Please address them before merging
* Add new version of NetworkTraversal, 2022-03-01-preview, with new parameter TTL * Add missing await in README * Update format * Add review API * Add correct version in Changelog * Add options bag for parameters when calling GetRelayConfiguration * Fix format * Update release date * Add missing entry in sms Changelog to fix build errors * Update PR addressing comments * Fix comment * Update PR
Packages impacted by this PR
Issues associated with this PR
None
Describe the problem that is addressed by this PR
Are there test cases added in this PR? (If not, why?)
Yes
Provide a list of related PRs (if any)
None
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists