[Digital Twins] Use "@azure-tools/test-credential";#20494
Merged
HarshaNalluru merged 1 commit intoAzure:mainfrom Feb 22, 2022
Merged
[Digital Twins] Use "@azure-tools/test-credential";#20494HarshaNalluru merged 1 commit intoAzure:mainfrom
HarshaNalluru merged 1 commit intoAzure:mainfrom
Conversation
ghost
added
the
HarshaNalluru
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Tests in digital-twins-core
Issues associated with this PR
#20493
Unblocks #20300
Describe the problem that is addressed by this PR
Fixes #20493
Requests from the AAD browser tests are hitting the live service in playback mode instead of using the recordings.
My best guess on the cause of the problem is that something has changed at the msal level which kicked in a tenant-id validation and failed for the "12345678-1234-1234-1234-123456789012" fake tenant-id.
Haven't investigated deeper on what is causing the failure, instead using the test-credential which would bypass the AAD traffic in playback mode.