Skip to content

[Text Analytics] Migrate to new recorder#20455

Merged
timovv merged 12 commits intoAzure:mainfrom
timovv:ai-text-analytics/19859-recorder-migration
Feb 19, 2022
Merged

[Text Analytics] Migrate to new recorder#20455
timovv merged 12 commits intoAzure:mainfrom
timovv:ai-text-analytics/19859-recorder-migration

Conversation

@timovv
Copy link
Copy Markdown
Member

@timovv timovv commented Feb 18, 2022

Packages impacted by this PR

  • @azure/ai-text-analytics

Issues associated with this PR

Describe the problem that is addressed by this PR

Migrates Text Analytics to new recorder.

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

Comment thread sdk/textanalytics/ai-text-analytics/test/public/utils/recordedClient.ts Outdated
Comment thread sdk/textanalytics/ai-text-analytics/test/public/textAnalyticsClient.spec.ts Outdated
Comment thread sdk/textanalytics/ai-text-analytics/test/public/utils/recordedClient.ts Outdated
Comment thread sdk/textanalytics/ai-text-analytics/test/public/utils/recordedClient.ts Outdated
Comment thread sdk/textanalytics/ai-text-analytics/test/public/utils/recordedClient.ts Outdated
Copy link
Copy Markdown
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I cannot believe SR and TA recording experience is much smoother now

Copy link
Copy Markdown
Member

@JonathanCrd JonathanCrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@timovv timovv merged commit 2fd836f into Azure:main Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants