[EventHubs] fix sample issue when running in build pipeline#20385
Merged
jeremymeng merged 1 commit intoAzure:mainfrom Feb 15, 2022
Merged
[EventHubs] fix sample issue when running in build pipeline#20385jeremymeng merged 1 commit intoAzure:mainfrom
jeremymeng merged 1 commit intoAzure:mainfrom
Conversation
ghost
added
the
Member
Author
|
/azp run js - event-hubs - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
The value provided to EVENTHUB_CONNECTION_STRING in the live test pipeline doesn't contain the event hub name so it's failing with error: TypeError: Either provide "eventHubName" or the "connectionString": "***", must contain "EntityPath=<your-event-hub-name>". This PR passes event hub name too to the client constructor in the same way as some other tests do.
jeremymeng
force-pushed
the
eh/fix-sample-env-var
branch
from
a0b1507 to
1b2d010
Compare
jeremymeng
requested review from
HarshaNalluru,
deyaaeldeen and
ramya-rao-a
as code owners
deyaaeldeen
approved these changes
Feb 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value provided to EVENTHUB_CONNECTION_STRING in the live test pipeline
doesn't contain the event hub name so it's failing with error:
This PR passes event hub name too to the client constructor in the same way as
some other tests do.
Fixes #20369