[Event Grid] Headerless Matcher to not check the dynamic headers#20345
Merged
HarshaNalluru merged 1 commit intoAzure:mainfrom Feb 11, 2022
Merged
[Event Grid] Headerless Matcher to not check the dynamic headers#20345HarshaNalluru merged 1 commit intoAzure:mainfrom
HarshaNalluru merged 1 commit intoAzure:mainfrom
Conversation
ellismg
approved these changes
Feb 11, 2022
Member
ellismg
left a comment
There was a problem hiding this comment.
Seems reasonable to me. I don't fully understand why the casing differs between the recordings and playback and to be honest I'm slightly confused as to why the uppercase UTF-8 appears in the recordings given that it seems we should be sending the lowercase version given the generated code. But I see how this would fix the issue and I agree the header matching is uninteresting for these test cases.
Contributor
Author
|
I'm unsure as well about what caused the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20343
Headerless matcher doesn't match the headers in playback.
This should make the CI green.