[Recorder] [Template] Fix browser test failure#20203
Merged
HarshaNalluru merged 6 commits intoAzure:mainfrom Feb 3, 2022
Merged
[Recorder] [Template] Fix browser test failure#20203HarshaNalluru merged 6 commits intoAzure:mainfrom
HarshaNalluru merged 6 commits intoAzure:mainfrom
Conversation
HarshaNalluru
requested review from
benbp,
mikeharder,
praveenkuttappan and
weshaggard
as code owners
ghost
added
the
HarshaNalluru
requested review from
jeremymeng,
maorleger,
scbedd and
witemple-msft
maorleger
approved these changes
Feb 3, 2022
Member
maorleger
left a comment
maorleger
left a comment
There was a problem hiding this comment.
🚀 LGTM, I do think a comment explaining this would be helpful but feel free to merge anyway to get things unblocked
HarshaNalluru
changed the title
HarshaNalluru
commented
Feb 3, 2022
… harsha/fix-template-browser-test
Contributor
Author
|
Looks like main branch has more changes to the template and the browser recording is empty somehow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
While we think of a better solution on how to handle the issue here Azure/azure-sdk-tools#2674, this PR ignores the header matching for the browser test in the template folder.
Read more here Azure/azure-sdk-tools#2674