Set "TestProxy: true" for template and identity pipelines#20122
Merged
HarshaNalluru merged 1 commit intoAzure:mainfrom Jan 28, 2022
Merged
Set "TestProxy: true" for template and identity pipelines#20122HarshaNalluru merged 1 commit intoAzure:mainfrom
HarshaNalluru merged 1 commit intoAzure:mainfrom
Conversation
HarshaNalluru
requested review from
benbp and
praveenkuttappan
as code owners
ghost
added
Azure.Identity
EngSys
HarshaNalluru
changed the title
timovv
approved these changes
Jan 28, 2022
sadasant
pushed a commit
to sadasant/azure-sdk-for-js
that referenced
this pull request
Jan 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
Not packages, but pipelines that are running tests with the help of test proxy tool
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Background:
In the CI/pipelines, mac agents are not capable of installing/using the docker, so we instead go by installing the "dotnet tool" directly in those machines and use the proxy tool without the docker command.
For the pipeline to know that, we use this variable "TestProxy".
Setting it to true means, a job will be added to the pipeline to install/start the proxy tool and dump the logs(For all the OSes).
It is not set to true by default already because not all pipelines are using TestProxy, and running the tool adds an unnecessary cost.
So, setting the TestProxy to true should make failing pipelines green.
Add as is shown here
azure-sdk-for-js/sdk/test-utils/ci.yml
Line 29 in d180f26
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists