[Monitor Query] fix the local time zone bug in the test#20096
Merged
KarishmaGhiya merged 1 commit intoAzure:mainfrom Jan 28, 2022
Merged
[Monitor Query] fix the local time zone bug in the test#20096KarishmaGhiya merged 1 commit intoAzure:mainfrom
KarishmaGhiya merged 1 commit intoAzure:mainfrom
Conversation
ghost
added
the
KarishmaGhiya
changed the title
Member
Author
|
@willmtemple This PR fixes the bug in the test happening locally which we noticed yesterday. |
KarishmaGhiya
added
the
Client
maorleger
approved these changes
Jan 27, 2022
Member
maorleger
left a comment
maorleger
left a comment
There was a problem hiding this comment.
🚀 seems fine to me assuming these inputs match reality
sadasant
pushed a commit
to sadasant/azure-sdk-for-js
that referenced
this pull request
Jan 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/monitor-query
Issues associated with this PR
No issue opened
Describe the problem that is addressed by this PR
There was an issue with an internal unit test -
convertTimespanToIntervalwhere the date conversion to ISO string() made the string to get converted in UTC timezone causing the test to fail locally, since the timezone wasn't specified in the date and it took the local timezone as default. This issue wasn't seen on the CI as the local timezone for CI is UTC.What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Not applicable
Are there test cases added in this PR? (If not, why?)
This fixes the test case.